Skip to content

Conversation

coronelnestorgaston05-ai

No description provided.

sliekens and others added 30 commits September 19, 2023 09:58
* [java] fixed feature test scenario check

* [java] support for non conentional version

* Update src/java/install.sh to not include whitespaces

Co-authored-by: Samruddhi Khandale <[email protected]>

* bumped patch version

---------

Co-authored-by: Samruddhi Khandale <[email protected]>
…ntainers#703)

* [common-utils] fix bug when user home is custom by base docker

* bumped minor version

* reduced conditions to improve readability
…containers#694)

* [python] Updated `sudo_if` function

- Remove double quotes to avoid issues with string tokenization

* Add test scenario

* Revert "Add test scenario"

This reverts commit 9e62a37.

* Update `jupyterlab git` package name

* Bump feature version

* Test: Install jupyterlab under root user

* Refactor changes

* Bump patch version

* Address review points
* add cuda tookit installing support

* add nvcc installing support

* add libcudnn8-dev installing support

* add new cuda versions adn cudnn versions

* add specificaitons of new option

* remove installNvcc

installNvcc process is included in installToolkit

* add tests for new nvidia-cuda options

* fix wrong scenario name

* Revert "add specificaitons of new option"

This reverts commit 0dcdb92.

README.md should be generated by CI workflow.

* make cudnn-dev installation isolated

* dump minor version to 1.1.0
* Terraform - Adds licensing information

* Update src/terraform/NOTES.md

Co-authored-by: Brigit Murtaugh <[email protected]>

---------

Co-authored-by: Brigit Murtaugh <[email protected]>
* Automated dotnet-install script update

* version bump

---------

Co-authored-by: github-actions <[email protected]>
* Bump the dotnet version after a script update

* Forgot to add file

* Keep 4 spaces indentation
Automated documentation update [skip ci]

Co-authored-by: github-actions <[email protected]>
* Docker-in-docker: Updates docker-init with "pkill"

* pkill only if container didn't start at first

* pkill with condition

* add back sudo_if
* Remove deprecated Python settings

* No longer install Python linters and formatters

* Revert "No longer install Python linters and formatters"

This reverts commit 57c7bec.

* Bump minor version
…efully (devcontainers#713)

* [terraform] Update retry logic

- Add `dnsutils` package to dependencies
- Update retry logic to handle DNS-related errors more gracefully

* Update install.sh

* Bump version
…ls (devcontainers#722)

* Try Ubuntu keyserver on port 80 if default HKP port fails

Closes devcontainers#719
Closes devcontainers#717

* Bump feature versions

---------

Co-authored-by: Samruddhi Khandale <[email protected]>
* Add PowerShell extension

* Bump feature version
Automated documentation update [skip ci]

Co-authored-by: github-actions <[email protected]>
* [common-utils] Bug fix: zsp missing rc snippet

* condion rc snippet

* fix bug

* remove debugging step
Remove the deprecated rebornix.Ruby extension from the list of installed extensions.
Automated documentation update [skip ci]

Co-authored-by: github-actions <[email protected]>
* Automated dotnet-install script update

* Bump version

---------

Co-authored-by: github-actions <[email protected]>
* Fix indentation in common-utils/main.sh

* common-utils: Fix install error on RHEL

On RHEL (and derivatives) the installation of the common-utils feature
could fail if the feature ran before (i.e., `PACKAGES_ALREADY_INSTALLED`
is set) and if either `INSTALL_ZSH` is false, or zsh was installed
earlier and `ZSH_ALREADY_INSTALLED` is true.

In these cases the script the `package_list` is empty, and `dnf`
terminates with the following error message:

```
usage: dnf install [-c [config file]] [-q] [-v] [--version]
                   [--installroot [path]] [--nodocs] [--noplugins]
                   [--enableplugin [plugin]] [--disableplugin [plugin]]
                   [--releasever RELEASEVER] [--setopt SETOPTS]
                   [--skip-broken] [-h] [--allowerasing] [-b | --nobest] [-C]
                   [-R [minutes]] [-d [debug level]] [--debugsolver]
                   [--showduplicates] [-e ERRORLEVEL] [--obsoletes]
                   [--rpmverbosity [debug level name]] [-y] [--assumeno]
                   [--enablerepo [repo]] [--disablerepo [repo] | --repo
                   [repo]] [--enable | --disable] [-x [package]]
                   [--disableexcludes [repo]] [--repofrompath [repo,path]]
                   [--noautoremove] [--nogpgcheck] [--color COLOR] [--refresh]
                   [-4] [-6] [--destdir DESTDIR] [--downloadonly]
                   [--comment COMMENT] [--bugfix] [--enhancement]
                   [--newpackage] [--security] [--advisory ADVISORY]
                   [--bz BUGZILLA] [--cve CVES]
                   [--sec-severity {Critical,Important,Moderate,Low}]
                   [--forcearch ARCH]
                   PACKAGE [PACKAGE ...]
dnf install: error: the following arguments are required: PACKAGE
```

Fix the problem by running `dnf` only with a non-zero `package_list`.
* revert behavior of sourcing .profile in .zprofile

https://github.com/devcontainers/features/pull/736/files#diff-3e71c0a0669a0410f7dd0d8f2b83f3b6bf6b525d3eabd354f19f32822da669fcR460-R463

* add test

* increment version

* create empty .zprofile is not present, and fix test

* temporarily add back .profile to .zprofile (only if file did not exist)
* fix typo

* version bump

---------

Co-authored-by: Eljo George <[email protected]>
Bump common-utils to v2.4.0 to reflect new package addition

Co-authored-by: Samruddhi Khandale <[email protected]>
…evcontainers#787)

* add option `useAttrPath` to support `nix-env -iA`

* add test and fix problem

* change to useAttributePath

* bump the version

* update test
trxcllnt and others added 28 commits June 11, 2025 17:16
…vcontainers#1367)

add plucky to the docker-outside-of-docker distro allow lists

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
* Node 18 EOL changes

* Fixing failing tests

* Updating based on review comments

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
Automated documentation update [skip ci]

Co-authored-by: github-actions <[email protected]>
Update VS Code extension references from 'ms-azuretools.vscode-docker' to 'ms-azuretools.vscode-containers' in Docker features

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
* fix(git): update Ubuntu PPA GPG key fingerprint

* Bump version

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
* [aws-cli] Change dependency from gnupg2 to gpg

Other components of gnupg2 are not necessary for verifying the aws-cli signature.

* version bump

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…s#1366)

* Ubuntu focal EOL change for nvidia-cuda

* Major version bump

* Major version bump correctly as per the review comment.

* Updating the correct version in readme file as pointed out in review.

* To re-run the tests

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…re (devcontainers#1395)

* [desktop-lite] - Adding support for noVNC latest version in the feature

* Corrections based on review comments.

* Correcting the logger statement.
…rs#1370)

* Ubuntu focal(20.04) EOL changes in features test scripts

* Version bump and dotnet rollback.

* Reverting the version bump & adding test for Oryx test script.

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…containers#1376)

* [rust] - Extending the feature support for non-debian platforms.

* Removing unused variables.

* corrections done based on review comments.

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…#1404)

* [rust] - Introducing new options to install components

* Fix for testing with rockylinux and addition in tests

* Correcting based on review comments.

* Further changes in the input

* correcting code comment

* Correcting based on review comment

* Correcting based on review comment.

* To rerun the test
* Support arm64 for CUDA image

* Update install.sh

* Update install.sh

* Update note

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…ers#1421)

* [terraform] - Fix terraform installation in ubuntu noble.

* Adding warning message.

* Small changes in the test scripts.

* Apply suggestions from code review, removing whitespaces.

Co-authored-by: Copilot <[email protected]>

* Apply suggestions from code review, to convert into a generic function.

Co-authored-by: Copilot <[email protected]>

* Adding further on review comments

* Update src/terraform/install.sh, updating comment.

Co-authored-by: Copilot <[email protected]>

* Update src/terraform/install.sh, removing whitespaces

Co-authored-by: Copilot <[email protected]>

* Further change to put function for common code as per review comment.

* Corrections done based on review comments.

* Further corrections.

* Update src/terraform/install.sh

Co-authored-by: Álvaro Rausell Guiard <[email protected]>

* Correction in error handling based on review comment.

* To check if able start tests

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…tainers#1342)

* anaconda feature installation support for arm64/ aarch64.

* Adding support for RHEL based linux distributions.

* Correction in the CONDA directory permission

* Update src/anaconda/install.sh, removing whitespaces

Co-authored-by: Copilot <[email protected]>

* Update src/anaconda/install.sh, removing whitespaces

Co-authored-by: Copilot <[email protected]>

* Update src/anaconda/install.sh

Co-authored-by: Copilot <[email protected]>

* Update src/anaconda/install.sh, removing whitespaces as suggested by copilot

Co-authored-by: Copilot <[email protected]>

* Update src/anaconda/install.sh, removing whitespaces

Co-authored-by: Copilot <[email protected]>

* Update test/anaconda/scenarios.json, removing whitespaces

Co-authored-by: Copilot <[email protected]>

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

* Correcting incorrect code review suggestion by Copilot

* Corrections based on review comments.

* Further corrections based on review comments.

---------

Co-authored-by: Kaniska244 <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Álvaro Rausell Guiard <[email protected]>
README.md was updated in devcontainers#1376, but NOTES.md was
left as is. The changes in README.md will be
overriden when CI will update the documentation
(e.g. with devcontainers#1408).

This PR also regenerates README.md, which fixes
the documentation for option `components`.

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…s#1423)

fix(devcontainer): bump javascript-node image version
…tainers#1424)

* Use new config to disable OhMyZsh auto update

There's a new method:
https://github.com/ohmyzsh/ohmyzsh/wiki/Settings#deprecated-settings

* bump patch version

* Remove `buster` from testing scenarios as it is EOL

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…-of-docker distro lists (devcontainers#1442)

* Add Debian Trixie to the docker-* distro list

* Grammar

* Fix Microsoft signing keys for Debian Trixie in docker-*

* Test docker installation on debian trixie

* Handle possibly missing moby package in docker-outside-of-docker installation

* Remove trixie test with `moby: true`

---------

Co-authored-by: Álvaro Rausell Guiard <[email protected]>
…evcontainers#1453)

* [ruby] - Making ruby feature work in debian trixie(13)

* Restart test
…tainers#1475)

* [terraform] - Fix terraform installation in debian trixie(13)

* Version bump
* dotnet: add support for prerelease versions

* Add 'additionalVersions' tests

* Improve handling of empty 'channel' and 'quality' values

* Fix invalid version spec in aspnetCoreRuntimeVersions
…nd putting a check to stop installation for Debian Trixie(13) (devcontainers#1482)

* [docker-in-docker, docker-outside-of-docker] - Update documentation and putting a check to stop installation for Debian Trixie(13)

* docker-in-docker feature test update

* Test script change
* Trixie Support

* Bump desktop lite version

* add trixie support to desktop lite test script

* Added test scenario for trixie

* Fix typo
…re (devcontainers#1478)

* Initial plan

* Fix excessive wget download output in GitHub CLI feature

Co-authored-by: Kaniska244 <[email protected]>

* Version bump.

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Kaniska244 <[email protected]>
@coronelnestorgaston05-ai coronelnestorgaston05-ai requested a review from a team as a code owner October 8, 2025 21:53

@coronelnestorgaston05-ai please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.