Skip to content

Conversation

@sireeshajonnalagadda
Copy link
Contributor

@sireeshajonnalagadda sireeshajonnalagadda commented Dec 2, 2025

Ref #1464

Initial builds of PHP 8.5 encountered issues due to the Xdebug extension not being available in the PECL repository at release time. The previously published version of Xdebug was incompatible with PHP 8.5, resulting in build failures as documented in this run. With the release of Xdebug 3.5.0 and its availability in PECL, the integration now functions as expected.

@sireeshajonnalagadda sireeshajonnalagadda marked this pull request as ready for review December 12, 2025 10:01
@sireeshajonnalagadda sireeshajonnalagadda requested a review from a team as a code owner December 12, 2025 10:01
Copilot AI review requested due to automatic review settings December 12, 2025 10:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for PHP 8.5 to the devcontainer images. The changes include a major version bump from 2.0.4 to 3.0.0, reflecting the addition of PHP 8.5 as the new default version and the removal of bullseye variants. The update was necessitated by the recent release of Xdebug 3.5.0, which is compatible with PHP 8.5.

Key Changes

  • Bumped manifest version from 2.0.4 to 3.0.0 (major version bump)
  • Added PHP 8.5 variants (8.5-apache-trixie and 8.5-apache-bookworm) and set 8.5-apache-trixie as the default
  • Removed bullseye variants and updated documentation to reflect trixie/bookworm-only support

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
src/php/manifest.json Major version bump to 3.0.0, added 8.5 variants with architecture support, updated variantTags to make 8.5 the default, removed bullseye variants
src/php/README.md Updated available image variants and version references to reflect PHP 8.5 support and version 3.0.0
src/php/.devcontainer/Dockerfile Changed default variant from 8.4-apache-trixie to 8.5-apache-trixie, updated xdebug comment to reference version 3.5.0
src/universal/.devcontainer/devcontainer.json Updated PHP feature to use version 8.5.0 with additionalVersions 8.4.15

@sireeshajonnalagadda sireeshajonnalagadda marked this pull request as draft December 15, 2025 04:40
@sireeshajonnalagadda sireeshajonnalagadda marked this pull request as ready for review December 15, 2025 07:07
@AlvaroRausell AlvaroRausell changed the title Add Support for Php 8.5 Add Support for PHP 8.5 and remove support for bullseye Dec 15, 2025
@AlvaroRausell AlvaroRausell merged commit 5babcf5 into devcontainers:main Dec 15, 2025
3 of 4 checks passed
@@ -1,4 +1,4 @@
ARG VARIANT=8.4-apache-trixie
ARG VARIANT=8.5-apache-trixie

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants