-
Notifications
You must be signed in to change notification settings - Fork 869
Add Support for PHP 8.5 and remove support for bullseye
#1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for PHP 8.5 and remove support for bullseye
#1676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for PHP 8.5 to the devcontainer images. The changes include a major version bump from 2.0.4 to 3.0.0, reflecting the addition of PHP 8.5 as the new default version and the removal of bullseye variants. The update was necessitated by the recent release of Xdebug 3.5.0, which is compatible with PHP 8.5.
Key Changes
- Bumped manifest version from 2.0.4 to 3.0.0 (major version bump)
- Added PHP 8.5 variants (8.5-apache-trixie and 8.5-apache-bookworm) and set 8.5-apache-trixie as the default
- Removed bullseye variants and updated documentation to reflect trixie/bookworm-only support
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/php/manifest.json | Major version bump to 3.0.0, added 8.5 variants with architecture support, updated variantTags to make 8.5 the default, removed bullseye variants |
| src/php/README.md | Updated available image variants and version references to reflect PHP 8.5 support and version 3.0.0 |
| src/php/.devcontainer/Dockerfile | Changed default variant from 8.4-apache-trixie to 8.5-apache-trixie, updated xdebug comment to reference version 3.5.0 |
| src/universal/.devcontainer/devcontainer.json | Updated PHP feature to use version 8.5.0 with additionalVersions 8.4.15 |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
bullseye
| @@ -1,4 +1,4 @@ | |||
| ARG VARIANT=8.4-apache-trixie | |||
| ARG VARIANT=8.5-apache-trixie | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Ref #1464
Initial builds of PHP 8.5 encountered issues due to the Xdebug extension not being available in the PECL repository at release time. The previously published version of Xdebug was incompatible with PHP 8.5, resulting in build failures as documented in this run. With the release of Xdebug 3.5.0 and its availability in PECL, the integration now functions as expected.