Bump up node feature version#1758
Conversation
There was a problem hiding this comment.
Pull request overview
Updates devcontainer feature lockfiles across multiple images (notably bumping the Node feature to 1.6.4), and adjusts the Miniconda image to account for the upstream continuumio/miniconda3 moving to Debian trixie.
Changes:
- Bump
ghcr.io/devcontainers/features/node:1to1.6.4(plus related feature bumps likegitandcommon-utils) across affecteddevcontainer-lock.jsonfiles. - Update Miniconda’s
.devcontainer/Dockerfileto validate Debiantrixieand usemcr.microsoft.com/devcontainers/base:2-trixie. - Bump Miniconda image
manifest.jsonversion and update Miniconda README tag examples accordingly.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/universal/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for the universal devcontainer. |
| src/typescript-node/.devcontainer/devcontainer-lock.json | Updates pinned git feature version for typescript-node devcontainer. |
| src/rust/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. common-utils/git) for rust devcontainer. |
| src/ruby/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for ruby devcontainer. |
| src/python/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for python devcontainer. |
| src/php/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for php devcontainer. |
| src/miniconda/manifest.json | Bumps Miniconda image version metadata. |
| src/miniconda/README.md | Updates Miniconda tag examples to match the new version. |
| src/miniconda/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for miniconda devcontainer. |
| src/miniconda/.devcontainer/Dockerfile | Updates Miniconda build to expect Debian trixie and use base:2-trixie. |
| src/jekyll/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for jekyll devcontainer. |
| src/javascript-node/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for javascript-node devcontainer. |
| src/java/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for java devcontainer. |
| src/java-8/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for java-8 devcontainer. |
| src/go/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for go devcontainer. |
| src/dotnet/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for dotnet devcontainer. |
| src/cpp/.devcontainer/devcontainer-lock.json | Updates pinned git feature version for cpp devcontainer. |
| src/base-ubuntu/.devcontainer/devcontainer-lock.json | Updates pinned feature versions for base-ubuntu devcontainer. |
| src/base-debian/.devcontainer/devcontainer-lock.json | Updates pinned feature versions for base-debian devcontainer. |
| src/base-alpine/.devcontainer/devcontainer-lock.json | Updates pinned common-utils feature version for base-alpine devcontainer. |
| src/anaconda/.devcontainer/devcontainer-lock.json | Updates pinned feature versions (incl. Node feature) for anaconda devcontainer. |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "1.1.14", | |||
| "version": "1.2.0", | |||
There was a problem hiding this comment.
The Miniconda image switches base OS from Debian bookworm to Debian trixie (and updates the base image from devcontainers/base:1-bookworm to devcontainers/base:2-trixie), which is a breaking change for consumers (package versions, glibc, etc.). The manifest.json version should be a major bump (e.g., 2.0.0) rather than 1.2.0 to follow semantic versioning for breaking base-OS changes.
| - `mcr.microsoft.com/devcontainers/miniconda:1-3` | ||
| - `mcr.microsoft.com/devcontainers/miniconda:1.1-3` | ||
| - `mcr.microsoft.com/devcontainers/miniconda:1.1.0-3` | ||
| - `mcr.microsoft.com/devcontainers/miniconda:1.2-3` | ||
| - `mcr.microsoft.com/devcontainers/miniconda:1.2.0-3` |
There was a problem hiding this comment.
The tag examples here should stay in sync with the image versioning scheme. If this release is a major bump due to the Debian bookworm→trixie switch, update these examples to use the new major version (and any other version references in this README) so users copy the correct tags.
See below for a potential fix:
- `mcr.microsoft.com/devcontainers/miniconda:2-3`
- `mcr.microsoft.com/devcontainers/miniconda:2.0-3`
- `mcr.microsoft.com/devcontainers/miniconda:2.0.0-3`
Running
devcontainer upgradefor all image variants to bump up node feature version1.6.4to ensure fix is included in dev build.Also
continuumio/miniconda3base image used by miniconda dev container, has been updated in Docker Hub today and it will be Debian trixie(13), accommodated small changes for that too.