Skip to content

Bug Fix Request: logic error issue for code review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+12 −0
Closed

Bug Fix Request: logic error issue for code review #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .prettierrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,18 @@ module.exports = {
*/
singleQuote: true,

// TODO: Review this implementation
java
public class Main {
public static void main(String[] args) {
int i = 0;
while(i != 0) {
Comment on lines +40 to +42
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite Loop Due to Incorrect Loop Condition

Java code has been incorrectly added to a JavaScript configuration file (.prettierrc.js). The code contains an infinite loop where a variable 'i' is initialized to 0 and then a while loop continues as long as 'i' is not equal to 0. Since 'i' is never modified within the loop, this condition will always be true, causing the application to hang indefinitely if executed. This violates ISO/IEC 25010 Functional Correctness requirements and would cause complete system failure.

References

Standard: ISO/IEC 25010 Functional Correctness - Execution Path Correctness

// do something
}
Comment on lines 36 to +44
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inappropriate Code in Configuration File

Java implementation code has been incorrectly added to a JavaScript configuration file (.prettierrc.js). This violates separation of concerns and file integrity principles. Configuration files should only contain configuration settings, not implementation code from other languages. This makes the configuration file difficult to maintain and could potentially break tools that parse this file expecting valid JavaScript configuration syntax.

// Configuration continues below

References

Standard: ISO/IEC 25010 Maintainability - Modularity, Clean Code Principles - File Organization

}
}


/**
* https://prettier.io/docs/en/options.html#quote-props
*/
Expand Down
Loading