Skip to content

perf: cache compiled regex patterns on braspagCards to avoid per-keyup RegExp construction #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: hotfix/error-recognition-flag
Choose a base branch
from
Draft

perf: cache compiled regex patterns on braspagCards to avoid per-keyup RegExp construction #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2939bca
Initial plan
Copilot Mar 2, 2026
c4070fc
perf: cache compiled regex patterns on card definitions to avoid repe…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions assets/js/braspag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@
}
];

// Pre-compile regex patterns once to avoid repeated compilation on every keyup
braspagCards.forEach(function (card) {
card._regex_include = card.regex_include ? new RegExp(card.regex_include) : null;

Check failure on line 152 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L152 

Found RegExp with non literal argument

Check warning on line 152 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L152 

Found non-literal argument to RegExp Constructor

Check failure on line 152 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L152 

The `RegExp` constructor was called with a non-literal value.
card._regex_exclude = card.regex_exclude ? new RegExp(card.regex_exclude) : null;

Check failure on line 153 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L153 

Found RegExp with non literal argument

Check warning on line 153 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L153 

Found non-literal argument to RegExp Constructor

Check failure on line 153 in assets/js/braspag.js

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

assets/js/braspag.js#L153 

The `RegExp` constructor was called with a non-literal value.
});

function Braspag() {
this.initialize();
}
Expand All @@ -170,23 +176,19 @@
card = braspagCards[_i];

let cardTypeFound = false;
if (card.regex_include != '') {
let regexIncludePattern = new RegExp(card.regex_include);

if (regexIncludePattern.test(num)) {
if (card._regex_include !== null) {
if (card._regex_include.test(num)) {
cardTypeFound = true;
}
}

if (cardTypeFound) {

if (card.regex_exclude == '') {
if (card._regex_exclude === null) {
return card;
}

let regexExcludePattern = new RegExp(card.regex_exclude);

if (!regexExcludePattern.test(num)) {
if (!card._regex_exclude.test(num)) {
return card;
}
}
Expand Down