Skip to content

Read SignedByte as i8, handle casting of Byte (u8) into unsigned types #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

Read SignedByte as i8, handle casting of Byte (u8) into unsigned types #95

merged 2 commits into from
May 8, 2025

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 8, 2025

What I am changing

  • Ensuring SignedByte -> i8 and Byte -> u8

How I did it

  • Raise TiffFormatError::ByteExpected in into_u8_vec
  • Support casting Byte to other unsigned types via the into_u16, into_u64, into_u16_vec, into_u32_vec and into_u64_vec methods.
  • Correctly cast Type::SBYTE as i8 values

How you can test it

  • Run cargo test locally

Related Issues

@weiji14 weiji14 self-assigned this May 8, 2025
@weiji14 weiji14 added the bug Something isn't working label May 8, 2025
@weiji14 weiji14 marked this pull request as ready for review May 8, 2025 17:05
@weiji14 weiji14 merged commit 0884082 into main May 8, 2025
6 checks passed
@weiji14 weiji14 deleted the byte_u8_sbyte_i8 branch May 8, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees

@weiji14 weiji14

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @kylebarron