-
Notifications
You must be signed in to change notification settings - Fork 1
chore: Modularize frontend architecture and remove ORCA code #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 28 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
314b754
update branding and add more repos
aboydnw 742d8f1
chore: cleanup PR for review
aboydnw ac82338
fix: resolve ruff linting and formatting errors
aboydnw 4480750
updated data
aboydnw 3dbada0
add filtering
aboydnw 6b14cc2
add vite
aboydnw 46034a5
break out modules from index.js
aboydnw 33a24bb
fix hover state offset
aboydnw 13c2c86
additional metrics
aboydnw e22d8e1
add community metrics for relevant repos
aboydnw 1287ea1
modularize the repo details panels, config, and styles
aboydnw d365bbc
extract state management and simulations
aboydnw 550cf5e
fix bugs from re-architecture
aboydnw 089f031
fix repo info card styling
aboydnw ec63e94
Merge main into update-frontend-architecture
aboydnw 5b01b74
remove ORCA specific code and update names to be more generic
aboydnw 1eb3fb4
remove vite
aboydnw 1a1d39f
remove vite and address code review changes
aboydnw be00dfa
bug fixes after removing vite
aboydnw 8c9cb56
fix title
aboydnw cc9a0ce
add back zoom
aboydnw b257c47
fix: remove node_modules from git tracking and add to .gitignore
aboydnw 648c94b
add node modules to gitignore
aboydnw 8047f6d
address merge conflicts
aboydnw b70bc3c
fix zoom
aboydnw fdbc504
clean up zoom action
aboydnw c9b1948
fix build error
aboydnw 85f9be4
fix build errors
aboydnw ab969c6
file structure fixes
aboydnw f94b7f6
remove other ds stores
aboydnw 782d2bb
project folder restructure
aboydnw 378210a
ci: add a build check
gadomski 9944f6c
fix: data locations
gadomski a2ebdc7
fix: build ci
gadomski e185369
fix: pages ci
gadomski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -215,3 +215,5 @@ __marimo__/ | |
| # Streamlit | ||
| .streamlit/secrets.toml | ||
|
|
||
| # Node.js | ||
| node_modules/ | ||
aboydnw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # Cleanup Summary - Chart Controls Removed | ||
|
|
||
| ## Issue | ||
| Chart controls (zoom +/-, center button) appeared in the visualization when they shouldn't have been present. | ||
|
|
||
| ## Root Cause | ||
| The old `/dist/` folder contained outdated build artifacts from previous development. This folder was created during earlier development phases and was no longer needed after: | ||
| - Removing Vite build system | ||
| - Flattening project structure to serve from root | ||
| - Rewriting index.html with clean ES6 modules | ||
|
|
||
| ## Solution Implemented | ||
| - ✅ Deleted `/dist/` folder and all its contents | ||
| - ✅ Verified root `index.html` has no control creation code | ||
| - ✅ Verified `src/js/` modules have no zoom/control code | ||
| - ✅ Confirmed clean project structure with single entry point | ||
|
|
||
| ## Files & Directories Removed | ||
| ``` | ||
| /dist/ (entire folder) | ||
| ├── index.html (old template version) | ||
| ├── index.js (old bundled copy) | ||
| ├── style.css (old copy) | ||
| ├── *.csv (old copies) | ||
| ├── d3*.js (old copies) | ||
| ├── src/ (old copy) | ||
| └── ... (other old files) | ||
| ``` | ||
|
|
||
| ## New Project Structure | ||
| ``` | ||
| contributor-network/ | ||
| ├── index.html ← Single entry point (clean, modular) | ||
| ├── index.js ← Main visualization | ||
| ├── style.css ← Stylesheet | ||
| ├── src/js/ ← 30+ modular ES6 components | ||
| │ ├── config/ | ||
| │ ├── data/ | ||
| │ ├── interaction/ | ||
| │ ├── layout/ | ||
| │ ├── render/ | ||
| │ ├── simulations/ | ||
| │ ├── state/ | ||
| │ └── utils/ | ||
| ├── d3*.js ← D3 libraries (local) | ||
| ├── *.csv ← Data files | ||
| └── ... (config, tests, docs) | ||
| ``` | ||
|
|
||
| ## What Changed | ||
| | Aspect | Before | After | | ||
| |--------|--------|-------| | ||
| | Entry points | `/` and `/dist/` | `/` only | | ||
| | Build system | Vite (removed) | None (direct ES6) | | ||
| | HTML versions | Multiple copies | Single clean version | | ||
| | File duplication | Many copies | Single source | | ||
| | Potential conflicts | High | None | | ||
|
|
||
| ## Testing | ||
| **To verify the fix:** | ||
| 1. Hard refresh browser: Ctrl+Shift+R (Windows) or Cmd+Shift+R (Mac) | ||
| 2. Visit: `http://localhost:8000/` | ||
| 3. Should see visualization with organization filter | ||
| 4. Should NOT see zoom controls (+/-, center button) | ||
| 5. Should NOT get 404 errors for dist/ files | ||
|
|
||
| ## Next Steps | ||
| 1. Hard refresh and test at `http://localhost:8000/` | ||
| 2. Verify no zoom controls appear | ||
| 3. Test all interactions work correctly | ||
| 4. Commit changes to git | ||
| 5. Submit PR with cleanup | ||
|
|
||
| ## Files Modified | ||
| - Deleted: `/dist/` folder (entire directory) | ||
|
|
||
| ## Code Quality Check | ||
| ✅ No zoom/button control code in source | ||
| ✅ No template-based HTML remaining | ||
| ✅ Clean modular architecture | ||
| ✅ Single entry point (root index.html) | ||
| ✅ No build system artifacts | ||
|
|
||
| ## Performance Impact | ||
| - Slightly reduced file count | ||
| - No server-side changes needed | ||
| - Faster development workflow (no build step) | ||
| - Cleaner git repository | ||
|
|
||
| ## Browser Compatibility | ||
| No changes to browser compatibility. Visualization still supports: | ||
| - Chrome 90+ | ||
| - Firefox 88+ | ||
| - Safari 14+ | ||
| - Edge 90+ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.