Refactor code structure for improved readability and maintainability

Author: emmanuelmathot

helm-chart/eoapi/.helmignore

@@ -22,3 +22,5 @@
 *.tmproj
 .vscode/
 tests/
+# Ignore all README.md in all subdirectories 
+README.md

helm-chart/eoapi/templates/_pgstac_init.tpl

@@ -0,0 +1,54 @@
+# Helm Chart Structure Refactoring
+
+This directory contains the refactored Helm chart templates for the EOAPI services.
+
+## Overview
+
+The templates have been refactored from a loop-based approach to a service-specific approach where each service has its own dedicated template files. This improves readability, maintainability, and flexibility.
+
+## Directory Structure
+
+```
+services/
+├── _common.tpl                # Limited common helper functions
+├── ingress.yaml               # Single ingress for all services
+├── traefik-middleware.yaml    # Traefik middleware for path stripping
+├── raster/                    # One directory per service
+│   ├── deployment.yaml
+│   ├── service.yaml
+│   ├── configmap.yaml
+│   └── hpa.yaml
+├── stac/
+│   ├── deployment.yaml
+│   ├── service.yaml
+│   ├── configmap.yaml
+│   └── hpa.yaml
+├── vector/
+│   ├── deployment.yaml
+│   ├── service.yaml
+│   ├── configmap.yaml
+│   └── hpa.yaml
+└── multidim/
+    ├── deployment.yaml
+    ├── service.yaml
+    ├── configmap.yaml
+    └── hpa.yaml
+```
+
+## Key Improvements
+
+1. **Enhanced Readability**: Each service's configuration is explicitly defined in its own files, making it easier to understand.
+2. **Improved Debugging**: Errors are isolated to specific service files, making troubleshooting simpler.
+3. **Lower Risk Changes**: Changes intended for one service are contained within its files, reducing the risk of affecting other services.
+4. **True Flexibility**: Each service can evolve independently, and new services can be added by copying and modifying existing patterns.
+5. **Limited Helper Functions**: Common logic is extracted into the `_common.tpl` file but only for the most mechanical, repetitive parts.
+
+## How to Use
+
+The chart maintains the same values.yaml structure but templates are now organized by service. The original looping templates have been preserved with `.old` extensions for reference.
+
+For adding a new service:
+1. Create a new directory with the service name
+2. Copy and adapt the deployment, service, configmap, and hpa templates
+3. Add an entry to ingress.yaml and traefik-middleware.yaml if needed
+4. Update values.yaml with the new service configuration

helm-chart/eoapi/templates/services/README.md

@@ -0,0 +1,58 @@
+{{/* 
+Helper function for mounting service secrets
+Only extract truly common elements that are mechanical and don't need customization
+*/}}
+{{- define "eoapi.mountServiceSecrets" -}}
+{{- $service := .service -}}
+{{- $root := .root -}}
+{{- if index $root.Values $service "settings" "envSecrets" }}
+{{- range $secret := index $root.Values $service "settings" "envSecrets" }}
+- secretRef:
+    name: {{ $secret }}
+{{- end }}
+{{- end }}
+{{- end -}}
+
+{{/*
+Helper function for common environment variables
+*/}}
+{{- define "eoapi.commonEnvVars" -}}
+{{- $service := .service -}}
+{{- $root := .root -}}
+- name: SERVICE_NAME
+  value: {{ $service | quote }}
+- name: RELEASE_NAME
+  value: {{ $root.Release.Name | quote }}
+- name: GIT_SHA
+  value: {{ $root.Values.gitSha | quote }}
+{{- end -}}
+
+{{/*
+Helper function for common init containers to wait for pgstac jobs
+*/}}
+{{- define "eoapi.pgstacInitContainers" -}}
+{{- if .Values.pgstacBootstrap.enabled }}
+initContainers:
+- name: wait-for-pgstac-jobs
+  image: bitnami/kubectl:latest
+  command:
+  - /bin/sh
+  - -c
+  - |
+    echo "Waiting for pgstac-migrate job to complete..."
+    until kubectl get job pgstac-migrate -o jsonpath='{.status.conditions[?(@.type=="Complete")].status}' | grep -q "True"; do
+      echo "pgstac-migrate job not complete yet, waiting..."
+      sleep 5
+    done
+    echo "pgstac-migrate job completed successfully."
+    
+    {{- if .Values.pgstacBootstrap.settings.loadSamples }}
+    echo "Waiting for pgstac-load-samples job to complete..."
+    until kubectl get job pgstac-load-samples -o jsonpath='{.status.conditions[?(@.type=="Complete")].status}' | grep -q "True"; do
+      echo "pgstac-load-samples job not complete yet, waiting..."
+      sleep 5
+    done
+    echo "pgstac-load-samples job completed successfully."
+    {{- end }}
+{{- end }}
+{{- end -}}