-
Notifications
You must be signed in to change notification settings - Fork 12
Adding support for configurable API paths #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ons, and item links with custom ingress paths
|
I think we also need to update the container start commands with the correct root path if these values are set (ex. https://github.com/developmentseed/eoapi-k8s/blob/services-prefixes/helm-chart/eoapi/templates/services/raster/deployment.yaml#L43). Running locally, I was able to change the ingress paths, but the STAC api was still pointing me back to |
|
@emmanuelmathot - just to coordinate - is this on you to take further? |
…le values for raster, stac, vector, and multidim services
|
The issue was that multiple files throughout the Helm chart had hardcoded path values that didn't respect the configurable ingress path settings: I updated all six files to use the configurable ingress path values from the Helm values: 1. Service Deployment Fileshelm-chart/eoapi/templates/services/stac/deployment.yaml:
helm-chart/eoapi/templates/services/raster/deployment.yaml:
helm-chart/eoapi/templates/services/vector/deployment.yaml:
helm-chart/eoapi/templates/services/multidim/deployment.yaml:
2. Traefik Middleware Configurationhelm-chart/eoapi/templates/services/traefik-middleware.yaml:
3. STAC Browser Configurationhelm-chart/eoapi/templates/services/browser/deployment.yaml:
@ividito Could you please make another test on your side? |
ividito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good on a local cluster, thanks @emmanuelmathot !
pantierra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up from my side as well.
sunu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well!
Overview
This PR adds support for configurable routing paths in the eoAPI stack, allowing operators to customize the base paths for each service (e.g., serving STAC under /api instead of /stac). This is particularly useful for integrations where specific path prefixes are required.
Changes
Example Usage
Testing
Notes
Closes #230