feat: Add Knative integration for notifications #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/ci-knative
branch
from
3735267 to
8528eba
Compare
pantierra
force-pushed
the
feature/ci-knative
branch
from
8528eba to
06fb9f3
Compare
pantierra
changed the title
pantierra
force-pushed
the
feature/ci-knative
branch
4 times, most recently
from
bdecd00 to
695abb7
Compare
pantierra
force-pushed
the
feature/ci-knative
branch
from
695abb7 to
dcaf3e4
Compare
ciaransweet
approved these changes
Oct 27, 2025
Contributor
ciaransweet
left a comment
ciaransweet
left a comment
There was a problem hiding this comment.
LGTM just general question on knative version
.github/workflows/helm-tests.yml
Outdated
| run: | | ||
| echo "=== Installing Knative Serving ===" | ||
| # Install Knative Serving CRDs | ||
| kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.17.0/serving-crds.yaml |
Contributor
There was a problem hiding this comment.
Do we maybe want to parameterise the knative version?
scripts/deploy.sh
Outdated
| fi | ||
|
|
||
| log_info "Installing Knative Serving..." | ||
| kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.17.0/serving-crds.yaml |
Contributor
There was a problem hiding this comment.
ditto the parameterising
pantierra
force-pushed
the
feature/ci-knative
branch
17 times, most recently
from
db6af1c to
bf51746
Compare
pantierra
force-pushed
the
feature/ci-knative
branch
21 times, most recently
from
c7bbe3b to
f99dd86
Compare
- Add CloudEvents sink deployment for eoapi-notifier integration - Configure dynamic secret name for PostgreSQL connection - Add local development configuration with reduced resources - Support both CI and local test environments
pantierra
force-pushed
the
feature/ci-knative
branch
from
f99dd86 to
f4af304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #326