feat: Add autoscaling tests #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/autoscaling-tests
branch
from
b691b61 to
f15a0ce
Compare
pantierra
force-pushed
the
feature/autoscaling-tests
branch
4 times, most recently
from
0ebcec4 to
f391d73
Compare
pantierra
force-pushed
the
feature/autoscaling-tests
branch
2 times, most recently
from
eefe17b to
1ed9576
Compare
ciaransweet
requested changes
Nov 14, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
117
to
120
| - name: Install Python dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pytest requests psycopg2-binary |
Contributor
There was a problem hiding this comment.
I think these can be installed in the pip install further up, rather than having two install steps
Contributor
Author
There was a problem hiding this comment.
Right, missed that one. Added them further up.
Comment on lines
191
to
212
| ###################### | ||
| # ADDITIONAL NOTES | ||
| ###################### | ||
| # | ||
| # To use this configuration: | ||
| # | ||
| # 1. Update the ingress.host to your actual domain | ||
| # 2. Adjust scaling targets based on your load testing results | ||
| # 3. Monitor resource usage and adjust requests/limits accordingly | ||
| # 4. Consider enabling TLS for production deployments | ||
| # | ||
| # IMPORTANT: This configuration enables monitoring components that are | ||
| # disabled by default. This is required for autoscaling to work. | ||
| # | ||
| # For observability and dashboards, install the separate eoapi-observability chart: | ||
| # helm install eoapi-obs eoapi/eoapi-observability --namespace eoapi | ||
| # | ||
| # Load testing recommendations: | ||
| # - Test each service endpoint individually | ||
| # - Monitor HPA metrics: kubectl get hpa -n eoapi -w | ||
| # - Check custom metrics: kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1" | ||
| # - Review Prometheus targets to ensure metrics collection is working |
Contributor
There was a problem hiding this comment.
I would probably put these steps at the top.
Contributor
Author
There was a problem hiding this comment.
Agreed. And moved up.
pantierra
force-pushed
the
feature/autoscaling-tests
branch
2 times, most recently
from
bb29db1 to
382256f
Compare
pantierra
force-pushed
the
feature/autoscaling-tests
branch
from
382256f to
028f651
Compare
ciaransweet
approved these changes
Nov 14, 2025
pantierra
added a commit
that referenced
this pull request
Nov 14, 2025
pantierra
added a commit
that referenced
this pull request
Nov 14, 2025
pantierra
added a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic testing of autoscaling options.