update pre-commit hooks and GHA#116
Merged
kylebarron merged 2 commits intodevelopmentseed:mainfrom Jan 2, 2025
Merged
Conversation
kylebarron
reviewed
Jan 1, 2025
| [tool.uv] | ||
| dev-dependencies = [ | ||
| "arro3-core>=0.4.2", | ||
| "black>=24.10.0", |
Member
There was a problem hiding this comment.
This is used in the docs to format code docstrings https://mkdocstrings.github.io/python/usage/#options-summary. It looks like the most recent version of mkdocstrings added the option for that to be done using ruff as well as black, so we can remove black as long as we ensure we're using the latest mkdocstrings.
Contributor
Author
There was a problem hiding this comment.
Gotcha, will double check
Contributor
Author
There was a problem hiding this comment.
@kylebarron done. I lower bound mkdocstrings and added ruff as dev dependency instead. now both the docs and the source code are using ruff as formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I am changing
uvto 0.5.xblackfrom dev deps, because it is not usedHow you can test it