Skip to content

Comments

Try to avoid refcount clone when importing PyObjectStore#119

Closed
kylebarron wants to merge 1 commit intomainfrom
kyle/avoid-refcount-clone
Closed

Try to avoid refcount clone when importing PyObjectStore#119
kylebarron wants to merge 1 commit intomainfrom
kyle/avoid-refcount-clone

Conversation

@kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 7, 2025

I don't think this is possible:

error: lifetime may not live long enough
  --> pyo3-object_store/src/store.rs:20:28
   |
18 | impl<'py> FromPyObject<'py> for PyObjectStore<'py> {
   |      --- lifetime `'py` defined here
19 |     fn extract_bound(ob: &Bound<'py, PyAny>) -> PyResult<Self> {
   |                          - let's call the lifetime of this reference `'1`
20 |         if let Ok(store) = ob.downcast::<PyS3Store>() {
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ argument requires that `'1` must outlive `'py`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant