Skip to content

Comments

Implement read_all for async iterable#140

Merged
kylebarron merged 4 commits intomainfrom
kyle/put-inner-read-all
Jan 15, 2025
Merged

Implement read_all for async iterable#140
kylebarron merged 4 commits intomainfrom
kyle/put-inner-read-all

Conversation

@kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 14, 2025

Change list

  • Implement read_all for AsyncPushSource
  • Change read_all to not copy buffer protocol input.

@kylebarron kylebarron marked this pull request as draft January 14, 2025 22:41
@kylebarron kylebarron marked this pull request as ready for review January 15, 2025 15:43
@kylebarron kylebarron enabled auto-merge (squash) January 15, 2025 15:47
@kylebarron
Copy link
Member Author

I'm not sure why but the tests just hung on c7f154f (#140). I reverted to using &mut self in read_all and we'll see if that does better.

@kylebarron kylebarron merged commit a14fb61 into main Jan 15, 2025
4 checks passed
@kylebarron kylebarron deleted the kyle/put-inner-read-all branch January 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant