Skip to content

Add tests for combining config and kwargs #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 1 commit into from
Jan 30, 2025
Merged

Add tests for combining config and kwargs #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/store/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import pytest

import obstore as obs
from obstore.exceptions import ObstoreError
from obstore.store import S3Store


Expand All @@ -20,3 +21,15 @@ async def test_get_async(s3_store: S3Store):
def test_construct_store_boolean_config():
# Should allow boolean parameter
S3Store("bucket", skip_signature=True)


def test_error_overlapping_config_kwargs():
with pytest.raises(ObstoreError, match="Duplicate key"):
S3Store("bucket", config={"skip_signature": True}, skip_signature=True)

# Also raises for variations of the same parameter
with pytest.raises(ObstoreError, match="Duplicate key"):
S3Store("bucket", config={"aws_skip_signature": True}, skip_signature=True)

with pytest.raises(ObstoreError, match="Duplicate key"):
S3Store("bucket", config={"AWS_SKIP_SIGNATURE": True}, skip_signature=True)