Support pickling & always manage store prefix#185
Merged
kylebarron merged 21 commits intomainfrom Jan 31, 2025
Merged
Conversation
2 tasks
This was referenced Jan 31, 2025
This was referenced Jan 31, 2025
Closed
Member
|
Thanks for your work on this @kylebarron! How do I get the prefix to be recognized when using e.g., from obstore.store import S3Store
import obstore as obs
bucket = "nasa-veda-scratch"
path = "zarr-obstore-test/max/zarr-v3/test-era5-v3-919"
# Open store with obstore
s3store = S3Store.from_url(f"s3://{bucket}/{path}")
stream = obs.list(s3store, chunk_size=10)
for list_result in stream:
print(list_result[0])
breakCurrently returns: |
Member
Author
|
Hmm this might be a bug in my prefix handling |
maxrjones
reviewed
Jan 31, 2025
Member
maxrjones
left a comment
There was a problem hiding this comment.
Is it possible to implement __getnewargs_ex__ for LocalStore?
Member
Author
|
@geospatial-jeff benchmarked this (from the 0.4.0-beta.1 tag) as maybe 3% slower than the previous 0.3.0, but that could be partially variation between tests, and would be worth it anyways for these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #184 for background
Changes
TODO:
Closes #125