Skip to content

bump to pyo3-0.23 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 4 commits into from
Dec 4, 2024
Merged

bump to pyo3-0.23 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b18f6ee
wip: bump to pyo3-0.23
kylebarron Nov 22, 2024
4b39f0a
bump versions
kylebarron Dec 4, 2024
c454b60
Bump to 0.23
kylebarron Dec 4, 2024
3dace5a
fix as_bytes to to_bytes
kylebarron Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
185 changes: 158 additions & 27 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ futures = "0.3.31"
http = "1.1"
indexmap = "2"
object_store = "0.11"
pyo3 = { version = "0.22", features = ["macros", "indexmap"] }
pyo3-async-runtimes = { version = "0.22", features = ["tokio-runtime"] }
pyo3-file = "0.9"
pyo3 = { version = "0.23", features = ["macros", "indexmap"] }
pyo3-async-runtimes = { version = "0.23", features = ["tokio-runtime"] }
pyo3-file = "0.10"
thiserror = "1"
tokio = "1.40"
url = "2"
Expand Down
3 changes: 1 addition & 2 deletions obstore/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ http = { workspace = true }
indexmap = { workspace = true }
object_store = { workspace = true }
pyo3 = { workspace = true, features = ["chrono"] }
# Latest git to get PyArrowBuffer constructor
pyo3-arrow = { git = "https://github.com/kylebarron/arro3", rev = "2c73b7695f66b14d4787db34ccb9b4922bb7f9c6" }
pyo3-arrow = "0.6"
pyo3-async-runtimes = { workspace = true, features = ["tokio-runtime"] }
pyo3-file = { workspace = true }
pyo3-object_store = { path = "../pyo3-object_store" }
Expand Down
2 changes: 1 addition & 1 deletion obstore/python/obstore/_buffer.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ class Buffer(_Buffer):
You can pass this to [`memoryview`][] for a zero-copy view into the underlying data.
"""

def as_bytes(self) -> bytes:
def to_bytes(self) -> bytes:
"""Copy this buffer into a Python `bytes` object."""
def __len__(self) -> int: ...
2 changes: 1 addition & 1 deletion obstore/python/obstore/fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async def _cat_ranges(
path, ranges = per_file_request
for buffer, ranges_ in zip(buffers, ranges):
initial_index = ranges_[2]
output_buffers[initial_index] = buffer.as_bytes()
output_buffers[initial_index] = buffer.to_bytes()

return output_buffers

Expand Down
Loading
Loading