wip: workflow to test helm deploy #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
force-pushed
the
main
branch
3 times, most recently
from
bdf9405 to
8ed08bc
Compare
Member
|
@batpad I'm going to close this. Feel free to re-open when you find the time to work on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #54
Creates some "test" helm charts that should get run as part of a
helm testthat verifies that the service is up and does a basic check that responses are 401 Unauthorized as expected.We can think about integrating an actual auth token with an
oidcendpoint down the line to also test successful authentication.@emmanuelmathot what do you think of this approach and using
helm testto run the tests? It seemed quite nice, but will try running things in CI, etc. and see if it makes sense to keep with this approach. Let me know if you have strong opinions against this kind of approach.cc @sunu