-
Notifications
You must be signed in to change notification settings - Fork 10
WIP: Support icechunk stores #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Henry Rodman <[email protected]>
I noticed that some tests fail with
in the This seems to only happen with caching is enabled (and only for the netcdf store)! To show this I have added an additional parametrization to the I did confirm that this error is introduced with the upgrade of either xarray or zarr here. When I just add the changes to Ill move on here for now, but I would love to fix this issue here. @hrodmn do you have any intuition why the caching would not play nice with a new xarray or zarr version? |
Ok making some progress here, but Ill need some input from folks. I have refactored the test datasets for zarr v2 and v3. The reading in seems to work (since the tests to get the variables only do pass), but I have some questions about the expected responses. when I run the
I am not exactly sure how these come about TBH. Are 'band_metadata', Happy to just rewrite the expected output, but I first wanted to understand exactly what is going on. All I could gather here was that these response fields are expected for e.g. the netcdf output. |
I am working towards icechunk (for now likely just native) support in titler-multidim here.
Depends on #95
Tasks