Skip to content

Improve JBoss EAP detection#284

Merged
thepetk merged 7 commits intodevfile:mainfrom
haoozhang:haozhan/jboss-eap
Jan 13, 2026
Merged

Improve JBoss EAP detection#284
thepetk merged 7 commits intodevfile:mainfrom
haoozhang:haozhan/jboss-eap

Conversation

@haoozhang
Copy link
Contributor

@haoozhang haoozhang commented Dec 3, 2025 •
edited
Loading

Description of Changes

This PR is to improve the detection of JBoss EAP framework.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

  • Unit/Functional tests

  • Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

[x] For each added clue, add the test project and unit test to verify it.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

References

  1. https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/7.3/html/development_guide/using_maven_with_eap
  2. https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/7.2/html/development_guide/using_maven_with_eap
  3. https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/7.0/html/development_guide/using_maven_with_eap
  4. https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/6.4/html/development_guide/sect-use_the_maven_repository#Configure_the_JBoss_Enterprise_Application_Platform_Maven_Repository_Using_the_Project_POM

@haoozhang haoozhang marked this pull request as ready for review December 9, 2025 10:06
@haoozhang
Copy link
Contributor Author

haoozhang commented Dec 9, 2025 •
edited
Loading

Hi @elsony @michael-valdron @Jdubrick @thepetk , could you please help to review this PR, thanks!

HaoZhang added 2 commits December 9, 2025 19:51
improve JBoss EAP detection
7f50307 
Signed-off-by: HaoZhang <haozhan@microsoft.com>
Merge remote-tracking branch 'origin/main' into haozhan/jboss-eap
4446a33 
Signed-off-by: HaoZhang <haozhan@microsoft.com>

# Conflicts:
#	test/apis/component_recognizer_test.go
fix conflict
51c2b44 
Signed-off-by: HaoZhang <haozhan@microsoft.com>
@thepetk
Copy link
Contributor

thepetk commented Dec 11, 2025

Hey @haoozhang! Thank you for your PR! I'll take a look in the next days :)

thepetk
thepetk approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice work @haoozhang!

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoozhang, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2026
@thepetk
Copy link
Contributor

thepetk commented Jan 9, 2026

Just a tiny comment before we merge. Regarding the test resources we are adding, We could think of reducing their size, after all we are only checking a specific file to find the framework/language.

reduce test resources size
da69136 
Signed-off-by: HaoZhang <haozhan@microsoft.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2026

New changes are detected. LGTM label has been removed.

@haoozhang
Copy link
Contributor Author

haoozhang commented Jan 12, 2026

Just a tiny comment before we merge. Regarding the test resources we are adding, We could think of reducing their size, after all we are only checking a specific file to find the framework/language.

Thanks for your comment, I just removed unnecessary files to reduce test resources size.

@haoozhang haoozhang requested a review from thepetk January 12, 2026 03:14
remove unnecessary test files
8756d71 
Signed-off-by: HaoZhang <haozhan@microsoft.com>
thepetk
thepetk reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @haoozhang now looks nice.

Might be good to have some more doc updates here too, for the JBoss detection

HaoZhang added 2 commits January 13, 2026 09:37
Merge remote-tracking branch 'origin/main' into haozhan/jboss-eap
ad84c91 
Signed-off-by: HaoZhang <haozhan@microsoft.com>

# Conflicts:
#	test/apis/component_recognizer_test.go
small update
916715c 
Signed-off-by: HaoZhang <haozhan@microsoft.com>
@haoozhang
Copy link
Contributor Author

haoozhang commented Jan 13, 2026

Hey @haoozhang now looks nice.

Might be good to have some more doc updates here too, for the JBoss detection

Hi @thepetk, I have updated the doc in another PR because it's already supported before this PR.
Now I resolved the merge conflict, please help to review again, thanks!

@thepetk thepetk merged commit f17ab9e into devfile:main Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thepetk thepetk thepetk approved these changes

@elsony elsony Awaiting requested review from elsony

@michael-valdron michael-valdron Awaiting requested review from michael-valdron

Assignees

@thepetk thepetk

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haoozhang @thepetk