add websphere and weblogic framework detector#292
Conversation
Signed-off-by: HaoZhang <haozhan@microsoft.com>
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
@haoozhang thanks again for your contribution!
Again here I think we could reduce the size of the test resources. I would also appreciate if you could include doc updates so we are sure that they stay up-to-date.
Overall functionality wise it looks good
Signed-off-by: HaoZhang <haozhan@microsoft.com>
Signed-off-by: HaoZhang <haozhan@microsoft.com>
Removed the unnecessary test files and updated the doc. Please help to review again. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoozhang, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Description of Changes
add websphere and weblogic framework detector
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.