Skip to content

Commit b1da7fd

Browse files
committed
fixup! fixup! chore: push base image to registry; update smoke tests to pull images
Signed-off-by: Oleksii Kurinnyi <[email protected]>
1 parent 24efb2d commit b1da7fd

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

.github/workflows/pr-check-ubi10.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,8 @@ jobs:
8585
registry: ${{ env.REGISTRY }}
8686
username: ${{ secrets.QUAY_USERNAME }}
8787
password: ${{ secrets.QUAY_PASSWORD }}
88-
- name: Pull base image
89-
run: |
90-
docker pull ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}}
91-
docker tag ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}} base-developer-image-${{env.arch}}
92-
- name: Display docker images
93-
run: docker images
9488
- name: Update UDI Dockerfile
95-
run: sed "s|quay.io/devfile/base-developer-image:ubi10-latest|base-developer-image-${{env.arch}}|" -i "universal/ubi10/Dockerfile"
89+
run: sed "s|quay.io/devfile/base-developer-image:ubi10-latest|${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}}|" -i "universal/ubi10/Dockerfile"
9690
- name: Add expiration label to UDI Dockerfile
9791
run: sed -i '/^FROM/a LABEL quay.expires-after=4w' universal/ubi10/Dockerfile
9892
- name: Build udi

.github/workflows/pr-check.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,8 @@ jobs:
8484
registry: ${{ env.REGISTRY }}
8585
username: ${{ secrets.QUAY_USERNAME }}
8686
password: ${{ secrets.QUAY_PASSWORD }}
87-
- name: Pull base image
88-
run: |
89-
docker pull ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}}
90-
docker tag ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}} base-developer-image-${{env.arch}}
91-
- name: Display docker images
92-
run: docker images
9387
- name: Update UDI Dockerfile
94-
run: sed "s|quay.io/devfile/base-developer-image:ubi9-latest|base-developer-image-${{env.arch}}|" -i "universal/ubi9/Dockerfile"
88+
run: sed "s|quay.io/devfile/base-developer-image:ubi9-latest|${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}}|" -i "universal/ubi9/Dockerfile"
9589
- name: Add expiration label to UDI Dockerfile
9690
run: sed -i '/^FROM/a LABEL quay.expires-after=4w' universal/ubi9/Dockerfile
9791
- name: Build udi

0 commit comments

Comments
 (0)