Skip to content

Conversation

@dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Jan 8, 2025

Adds the linux/arm64 platform, just like in the ubi build:

platforms: linux/amd64, linux/arm64

@dkwon17 dkwon17 requested review from SDawley and svor as code owners January 8, 2025 15:29
@svor
Copy link
Collaborator

svor commented Jan 8, 2025

@dkwon17 in Dockerfile Some binaries that are downloaded are specific to the amd64 architecture. Should we adapt them for arm64 compatibility?

@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, ibuziuk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Jan 10, 2025

@svor good idea, I'll see if I can do that this Friday

Signed-off-by: David Kwon <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jan 12, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2025

New changes are detected. LGTM label has been removed.

Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkwon17 did you have a chance to build udi for arm64?
I've tried DOCKER_BUILDKIT=1 docker image build --platform linux/arm64 --progress=plain -t quay.io/devfile/universal-developer-image:ubi9-latest .
but had an error:

#9 0.387 exec /bin/sh: exec format error
#9 ERROR: process "/bin/sh -c touch ${PROFILE_EXT} && chown 10001 ${PROFILE_EXT}" did not complete successfully: exit code: 1
------
 > [ 2/44] RUN touch /etc/profile.d/udi_environment.sh && chown 10001 /etc/profile.d/udi_environment.sh:
0.387 exec /bin/sh: exec format error
------
Dockerfile:26
--------------------
  24 |     # $PROFILE_EXT contains all additions made to the bash environment
  25 |     ENV PROFILE_EXT=/etc/profile.d/udi_environment.sh
  26 | >>> RUN touch ${PROFILE_EXT} && chown 10001 ${PROFILE_EXT}
  27 |     
  28 |     USER 10001

It would be nice to have a PR check that checks image build for all arches

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Jan 15, 2025

Yes, I was able to build for the udi for arm64 with this PR, I will investigate

@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Feb 12, 2025

Closed in favour of #216

@dkwon17 dkwon17 closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants