Skip to content

Conversation

@olexii4
Copy link
Collaborator

@olexii4 olexii4 commented Feb 6, 2025

What does this PR do?

This PR added support for devfile attributes for schema version 2.0.0 and removed adding che.eclipse.org/devfile attribute from the target devworkspace.

What issues does this PR fix or reference?

It needs for eclipse-che/che#23301

Is it tested? How?

@olexii4 olexii4 force-pushed the CHE-23301 branch 7 times, most recently from e315a78 to 81feab7 Compare February 6, 2025 23:53
Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 the codebase looks good to me.
May I ask you to provide an example of devfile that I can use for testing and why it's only related to 2.0.0 version (it's just for my understanding)?

Also I asked @RomanNikitenko to confirm that these changes won't break che-code functionality

@RomanNikitenko
Copy link
Contributor

@vitaliy-guliy
the PR changes potentially can affect Restart Workspace from Local Devfile command on the che-code side.
so, could you review these changes as well
thanks!

@vitaliy-guliy
Copy link

@vitaliy-guliy the PR changes potentially can affect Restart Workspace from Local Devfile command on the che-code side. so, could you review these changes as well thanks!

I would take some time to test the PR.

I think we need to rebuild both devworkspace-generator and che-code with the changes introduced by this PR.
Only giving that we can test che-code carefully.

@olexii4
Copy link
Collaborator Author

olexii4 commented Feb 12, 2025

This PR need for eclipse-che/che-dashboard#1315

@vitaliy-guliy
Copy link

I tried to test changes in this PR, but build is failed because of previous changes #64.
I think we have to adapt to that changes and then proceed with this pull request


jobs:
dash-licenses:
runs-on: ubuntu-22.04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkuznyetsov just to be on the safe side this runner is NOT deprecated?

Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
let's wait for @vitaliy-guliy's review

Copy link

@vitaliy-guliy vitaliy-guliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built che-code applying changes from this pull request and have checked how does restart workspace from local devfile work.

Screenshot from 2025-02-20 13-11-09

At the moment I do not see any regressions.

@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, svor, vitaliy-guliy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vitaliy-guliy
Copy link

che-code UBI8-adm64 image quay.io/vgulyy/che-code:test-devworkspace-generator

@olexii4 olexii4 merged commit 1ccb963 into main Feb 20, 2025
5 checks passed
@olexii4 olexii4 deleted the CHE-23301 branch February 20, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants