-
Notifications
You must be signed in to change notification settings - Fork 5
fix: Add support for devfile attributes for schema version 2.0.0 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e315a78 to
81feab7
Compare
svor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olexii4 the codebase looks good to me.
May I ask you to provide an example of devfile that I can use for testing and why it's only related to 2.0.0 version (it's just for my understanding)?
Also I asked @RomanNikitenko to confirm that these changes won't break che-code functionality
|
@vitaliy-guliy |
I would take some time to test the PR. I think we need to rebuild both devworkspace-generator and che-code with the changes introduced by this PR. |
|
This PR need for eclipse-che/che-dashboard#1315 |
|
I tried to test changes in this PR, but build is failed because of previous changes #64. |
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
Signed-off-by: Oleksii Orel <[email protected]>
|
|
||
| jobs: | ||
| dash-licenses: | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkuznyetsov just to be on the safe side this runner is NOT deprecated?
svor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
let's wait for @vitaliy-guliy's review
vitaliy-guliy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, svor, vitaliy-guliy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
che-code UBI8-adm64 image quay.io/vgulyy/che-code:test-devworkspace-generator |

What does this PR do?
This PR added support for devfile attributes for schema version 2.0.0 and removed adding
che.eclipse.org/devfileattribute from the target devworkspace.What issues does this PR fix or reference?
It needs for eclipse-che/che#23301
Is it tested? How?