Skip to content

Conversation

@michael-valdron
Copy link
Member

Description of Changes

Enables automerging for Konflux patch PRs, automerge will occur if PRs are from the tekton manager and all branch protections are met (approvals and required checks pass).

Additional changes

  • Fixes the schedule cron string to connect time intervals (i.e. schedule 7pm-2am Tuesdays and Thursdays is actually 7-11:59pm Tuesdays and Thursday and 12-2am Wednesdays and Fridays)

Related Issue(s)

part of devfile/api#1686

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@openshift-ci openshift-ci bot requested review from elsony and thepetk November 19, 2025 15:37
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2025
@michael-valdron michael-valdron requested a review from a team November 19, 2025 15:38
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

not sure if we should also set Require status checks to pass before merging (i don't have access) in the main branch ruleset so we are sure that renovate won't merge PRs with approval but also failing PR checks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/lgtm

not sure if we should also set Require status checks to pass before merging (i don't have access) in the main branch ruleset so we are sure that renovate won't merge PRs with approval but also failing PR checks

@thepetk Looks like we're good for registry-support with the required checks:

image

@michael-valdron michael-valdron merged commit 521d0c7 into devfile:main Nov 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants