Skip to content

Conversation

@maximilianoPizarro
Copy link
Collaborator

@maximilianoPizarro maximilianoPizarro commented Sep 10, 2024

Description of Changes

Add jhipster-online devfile.yaml and Dockerfile image from quay.io/devfile/universal-developer-image with jhipster-generator 8.1.0.

How To Test

Works in Developer Sandbox

JHipster Online on Red Hat OpenShift Dev Spaces

java nodejs Angular Spring Redhat kubernetes Docker shell linkedin

Install JHipster Online on OpenShift Dev Spaces

  1. Login with your Red Hat Account. https://console.redhat.com/openshift/sandbox. Select "OpenShift Dev Spaces".

  1. Complete Git Repo URL parameter with the repo URL: https://github.com/maximilianoPizarro/jhipster-online

  1. Run Tasks from devfile in your Red Hat DevSpaces.

Taking a look at the Video Demo

JHipster Online on Red Hat Developer Sandbox

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2024

Hi @maximilianoPizarro. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?

Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron

@Jdubrick
Copy link
Contributor

/ok-to-test

@maximilianoPizarro
Copy link
Collaborator Author

Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?

Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron

Hi Team,

Absolutely yes! Add me owner from this solution.

Thanks in advance!

@maximilianoPizarro
Copy link
Collaborator Author

/retest

1 similar comment
@maximilianoPizarro
Copy link
Collaborator Author

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments :)

Signed-off-by: Maximiliano Pizarro <[email protected]>
@maximilianoPizarro
Copy link
Collaborator Author

/retest

@maximilianoPizarro
Copy link
Collaborator Author

Hi Team!

The last week I was recording a video about this integration. You see the video on my Youtube Channel or click on this image.

JHipster Online on Red Hat Developer Sandbox

The JHipster community supports the initiative published in this Linkedin post on my profile.

I remain attentive to any concerns.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get this imported in devspaces and everything seems to be working as intended, when trying to test with odo I ran into an issue with the mysql but that may have been my initial setup.

At this point in time I believe we are just waiting on time for our team to have a discussion around how to handle giving you ownership over this stack, correct me if I am wrong @thepetk @michael-valdron . After that discussion I think we can proceed with finalizing the PR review

@maximilianoPizarro
Copy link
Collaborator Author

Hi team! Do we have any status on PR review? Do you need anything from me? Thanks in advance 🙌

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #495 has been merged and we have updated our process for adding new stacks we can proceed with this one. If you would like to continue to add this stack after reviewing the new lifecycle changes re: your ownership in the PR I linked above, would you mind adding this stack to https://github.com/devfile/registry/blob/main/.github/CODEOWNERS as part of this PR? I included the snippet to add below:

# JHipster stacks - On trial 
/stacks/jhipster-online/ @devfile/devfile-services-team @devfile/che-team

wdyt @thepetk @michael-valdron

Signed-off-by: Maximiliano Pizarro <[email protected]>
@maximilianoPizarro
Copy link
Collaborator Author

/retest

1 similar comment
@maximilianoPizarro
Copy link
Collaborator Author

/retest

Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
@maximilianoPizarro
Copy link
Collaborator Author

/retest

@maximilianoPizarro
Copy link
Collaborator Author

Now that #495 has been merged and we have updated our process for adding new stacks we can proceed with this one. If you would like to continue to add this stack after reviewing the new lifecycle changes re: your ownership in the PR I linked above, would you mind adding this stack to https://github.com/devfile/registry/blob/main/.github/CODEOWNERS as part of this PR? I included the snippet to add below:

# JHipster stacks - On trial 
/stacks/jhipster-online/ @devfile/devfile-services-team @devfile/che-team

wdyt @thepetk @michael-valdron

Hi @Jdubrick, the last changes are ready. Have a good weekend. greeting!

@Jdubrick
Copy link
Contributor

Hmm, adding the approved label doesn't allow Konflux tests to trigger, is this intended @michael-valdron?

@Jdubrick
Copy link
Contributor

/ok-to-test

@michael-valdron
Copy link
Member

Hmm, adding the approved label doesn't allow Konflux tests to trigger, is this intended @michael-valdron?

I tried also /approve and /lgtm but yet again it didn't trigger the status check

@thepetk @Jdubrick Let's skip for this PR as it could just be flaky since we added after this was created and its not a required check, but lets keep an eye on this for future PRs and open a bug report if it happens again.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Nov 27, 2024
Copy link
Collaborator Author

@maximilianoPizarro maximilianoPizarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the versions from stack.yaml

@maximilianoPizarro
Copy link
Collaborator Author

maximilianoPizarro commented Nov 27, 2024

@maximilianoPizarro Just have the one feedback right now: https://github.com/devfile/registry/pull/480/files#r1759350378

Hi @michael-valdron. I removed versions from stack but CI process fail with this error:

50.47 Error: failed to generate index struct: jhipster-online stack.yaml is not valid: [versions list is not set stack.yaml, or is empty stack.yaml does not contain a default version]
50.47 Failed to build the devfile registry index

Now try remove version from devfile.yaml

@michael-valdron
Copy link
Member

@maximilianoPizarro Just have the one feedback right now: https://github.com/devfile/registry/pull/480/files#r1759350378

Hi @michael-valdron. I removed versions from stack but CI process fail with this error:

50.47 Error: failed to generate index struct: jhipster-online stack.yaml is not valid: [versions list is not set stack.yaml, or is empty stack.yaml does not contain a default version] 50.47 Failed to build the devfile registry index

Now try remove version from devfile.yaml

Yeah meant the version field, you'll still need versions to manage the different versions of this stack.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Nov 27, 2024
@maximilianoPizarro
Copy link
Collaborator Author

@maximilianoPizarro Just have the one feedback right now: https://github.com/devfile/registry/pull/480/files#r1759350378

Hi @michael-valdron. I removed versions from stack but CI process fail with this error:
50.47 Error: failed to generate index struct: jhipster-online stack.yaml is not valid: [versions list is not set stack.yaml, or is empty stack.yaml does not contain a default version] 50.47 Failed to build the devfile registry index
Now try remove version from devfile.yaml

Yeah meant the version field, you'll still need versions to manage the different versions of this stack.

@michael-valdron remove version from devfile and now find a new error:

Error: failed to generate index struct: jhipster-online index component is not valid: index component versions list contains an entry with no version specified.

Do I add the version to devfile.yaml as it was before?

@michael-valdron
Copy link
Member

Do I add the version to devfile.yaml as it was before?

@maximilianoPizarro Yes, version should be under devfile.yaml of the stack version not stack.yaml.

Signed-off-by: Maximiliano Pizarro <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Nov 27, 2024
maximilianoPizarro and others added 7 commits November 27, 2024 19:10
Signed-off-by: Maximiliano Pizarro <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
@maximilianoPizarro
Copy link
Collaborator Author

/retest

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Nov 28, 2024
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, maximilianoPizarro, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit cc09232 into devfile:main Nov 28, 2024
11 of 12 checks passed
@ibuziuk
Copy link
Collaborator

ibuziuk commented Dec 18, 2024

@maximilianoPizarro thank you for the contribution
I want to promote new devfile on the Eclipse Che website - eclipse-che/che-website#112
However, it does not seem to work for me, could you please take a look - eclipse-che/che-website#112 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants