-
Notifications
You must be signed in to change notification settings - Fork 96
add jhipster-online project #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @maximilianoPizarro. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Jdubrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?
Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron
|
/ok-to-test |
Hi Team, Absolutely yes! Add me owner from this solution. Thanks in advance! |
|
/retest |
1 similar comment
|
/retest |
thepetk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments :)
Signed-off-by: Maximiliano Pizarro <[email protected]>
|
/retest |
Jdubrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get this imported in devspaces and everything seems to be working as intended, when trying to test with odo I ran into an issue with the mysql but that may have been my initial setup.
At this point in time I believe we are just waiting on time for our team to have a discussion around how to handle giving you ownership over this stack, correct me if I am wrong @thepetk @michael-valdron . After that discussion I think we can proceed with finalizing the PR review
|
Hi team! Do we have any status on PR review? Do you need anything from me? Thanks in advance 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #495 has been merged and we have updated our process for adding new stacks we can proceed with this one. If you would like to continue to add this stack after reviewing the new lifecycle changes re: your ownership in the PR I linked above, would you mind adding this stack to https://github.com/devfile/registry/blob/main/.github/CODEOWNERS as part of this PR? I included the snippet to add below:
# JHipster stacks - On trial
/stacks/jhipster-online/ @devfile/devfile-services-team @devfile/che-team
wdyt @thepetk @michael-valdron
Signed-off-by: Maximiliano Pizarro <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
|
/retest |
Hi @Jdubrick, the last changes are ready. Have a good weekend. greeting! |
|
Hmm, adding the |
|
/ok-to-test |
@thepetk @Jdubrick Let's skip for this PR as it could just be flaky since we added after this was created and its not a required check, but lets keep an eye on this for future PRs and open a bug report if it happens again. |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maximilianoPizarro Just have the one feedback right now: https://github.com/devfile/registry/pull/480/files#r1759350378
Signed-off-by: Maximiliano Pizarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the versions from stack.yaml
Hi @michael-valdron. I removed versions from stack but CI process fail with this error: 50.47 Error: failed to generate index struct: jhipster-online stack.yaml is not valid: [versions list is not set stack.yaml, or is empty stack.yaml does not contain a default version] Now try remove version from devfile.yaml |
Signed-off-by: Maximiliano Pizarro <[email protected]>
Yeah meant the |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@michael-valdron remove version from devfile and now find a new error: Error: failed to generate index struct: jhipster-online index component is not valid: index component versions list contains an entry with no version specified. Do I add the version to devfile.yaml as it was before? |
@maximilianoPizarro Yes, |
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Co-authored-by: Michael Valdron <[email protected]> Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
|
/retest |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Jdubrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, maximilianoPizarro, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@maximilianoPizarro thank you for the contribution |

Description of Changes
Add jhipster-online devfile.yaml and Dockerfile image from quay.io/devfile/universal-developer-image with jhipster-generator 8.1.0.
How To Test
Works in Developer Sandbox
JHipster Online on Red Hat OpenShift Dev Spaces
Install JHipster Online on OpenShift Dev Spaces
Taking a look at the Video Demo