Go 1.24 for 1.x stack version #621
Conversation
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
lgtm, one question I have is about the 2.x version. Will it be covered by another PR? I don't think the failures of CI are related with the changes of the PR
Also not-related but should we start thinking about deprecating the older versions of this stack?
@michael-valdron ignore my comment for 2.x just noticed #622 |
Yes, think we should both start deprecating stack version across our owned stacks and pinning the starter project references for each stack version so starter project changes don't break the stack. FYI @devfile/devfile-services-team |
michael-valdron
force-pushed
the
go1.24-stack-1.x
branch
from
ad92ee8 to
e7341d8
Compare
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
force-pushed
the
go1.24-stack-1.x
branch
from
e7341d8 to
df897ee
Compare
|
Hi @devfile/che-team, need a review from one of you 👀 |
|
/retest |
|
@thepetk looks good? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, svor, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of Changes
Cuts new stack version for Go stack that provides 1.24 Go version.
Related Issue(s)
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.