chore: removing obsolete / deprecated EoL .Net 3.1, 5.0, 6.0 #627
Conversation
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
According to the lifecycle policy we have in place, we could start by adding the deprecated tag in the stack and then after a 3 months period remove it.
In case we decide to keep open this PR, we need also to remove the records from the CODEOWNERS file:
Line 14 in fc77c5c
|
@thepetk sorry, but why can't we just remove it? Runtime deprecation happened a long time ago on the Microsoft's end, and on the devfile.io landing page [1] you currently promote obsolete samples at the first place that probably no one is using - |
@ibuziuk as also discussed internally, according to our docs & policies in the end is up to the stack owner to decide that. As discussed @kadel (the dotnet stacks owner) is OK to remove them, so we can merge this one. |
|
@ibuziuk per your questions for the samples -> all samples are loaded from here: https://github.com/devfile/registry/blob/main/extraDevfileEntries.yaml Let me know if you need any further info from my side |
|
/retest |
Signed-off-by: Ilya Buziuk <[email protected]>
Signed-off-by: Ilya Buziuk <[email protected]>
Signed-off-by: Ilya Buziuk <[email protected]>
ibuziuk
force-pushed
the
dotnet_deprecated
branch
from
6624046 to
98d81d2
Compare
|
@thepetk could you please point me where the tests are expected to be updated? |
|
/retest |
1 similar comment
|
/retest |
|
Seems persistent.. I'll have to open a ticket in the morning to see what's going on |
|
@michael-valdron @thepetk thank you for the follow-up. Just to clarify, there is nothing required from my end at this point, right? |
|
heya, any update? how can we proceed with the removal and what is blocking the merge at this point? |
|
/retest |
|
@ibuziuk I've opened a ticket with the test platform team about our failing OpenShift testing check having failing authentication errors just waiting for a follow up now. Also, the additional recent failed EC check is due to a wide spread issue with the Konflux infrastructure and hopefully will be resolved by the time the OpenShift testing check is resolved. |
|
@michael-valdron re-running the failed jobs 👍 |
|
@michael-valdron @thepetk still failing :/ what should we do ? |
@ibuziuk The GH action checks are failing because the test delta still picks up completely removed (not considering cases where the stacks are removed) whereas the openshift testing check also runs the odo v3 check but on all in the current state rather than a test delta there it passes: registry/.ci/openshift_integration.sh Line 81 in 35627b4 For this PR I'll ignore these failures since we know its just because the test delta is still picking up the removed stacks and the required tests are passing now. I'll open up a follow up issue to address this in future cases. cc @thepetk |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
/lgtm
Works as expected and non of the deprecated stacks/samples are present:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibuziuk, kadel, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ibuziuk @michael-valdron I've approved and merged so it can be also included in today's weekly promotion. |
Description of Changes
Deprecation Status of .NET Versions
NET 3.1 was a Long-Term Support (LTS) release, but its support ended on December 13, 2022. Since then, it has been considered deprecated.
NET 5.0 was a Standard Term Support (STS) release, and its support ended much earlier, on May 10, 2022, making it a deprecated version. STS releases have a shorter lifecycle of 18 months.
NET 6.0 was also a Long-Term Support (LTS) release, but its support officially ended on November 12, 2024. This makes it a deprecated version.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.