Skip to content

Conversation

@eebbi
Copy link
Contributor

@eebbi eebbi commented Feb 18, 2025

Severa-ID: 2108
Severa-kuvaus: TMS-1100 Tapahtumaan useampi paikka näkyviin
Task: https://hiondigital.atlassian.net/browse/TMS-1100

Description

  • Show multiple locations for events if available
  • Add "and other locations" text in event-highlights if multiple locations exist

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@eebbi eebbi requested a review from a team February 18, 2025 09:18
@HPiirainen HPiirainen self-assigned this Feb 18, 2025
Copy link
Contributor

@HPiirainen HPiirainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muutama huomio

*
* @return array
*/
public static function count_locations( $event ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kuvaavampi voisi olla ehkä joku get_locations_count_string tms., kun käännöksestä kyse, mutta ei tarvi muuttaa.

lib/Eventz.php Outdated
/**
* Get event location.
*
* @param object $event Event object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ylimääräisiä spaceja

lib/Eventz.php Outdated
}

/**
* Get event location.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kommentin voisi tarkentaa

</span>

{date|kses}
<p class="mt-0 mb-0">{date|kses}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olikohan Bulmassa my-0 joka laittaa y-akselin marginit nolliin 🤔 ei tarvi vaihtaa, aika pieni optimointi, jos tollasta edes oli olemassa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taitaa löytyä my-0, mutta päätin tehdä näin kun copy-pastesin nää muutokset jokaiseen museoteemaankin, niin tää pitää ainakin varmana ettei häviä tyylejä jos jostain sattuu löytymään sivuttais-margineita 🤓

{/event.normalized.location}
{/event.normalized.multiple_locations}

{?event.normalized.multiple_locations}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olisi voinut tehdä vain "if-elsen" eikä ensin "if not" ja sen jälkeen "if"

@eebbi eebbi merged commit 1229b7d into master Feb 23, 2025
3 of 4 checks passed
@eebbi eebbi deleted the TMS-1100 branch February 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants