-
Notifications
You must be signed in to change notification settings - Fork 0
TMS-1100: Show multiple locations for events if available #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HPiirainen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muutama huomio
| * | ||
| * @return array | ||
| */ | ||
| public static function count_locations( $event ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kuvaavampi voisi olla ehkä joku get_locations_count_string tms., kun käännöksestä kyse, mutta ei tarvi muuttaa.
lib/Eventz.php
Outdated
| /** | ||
| * Get event location. | ||
| * | ||
| * @param object $event Event object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ylimääräisiä spaceja
lib/Eventz.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Get event location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kommentin voisi tarkentaa
| </span> | ||
|
|
||
| {date|kses} | ||
| <p class="mt-0 mb-0">{date|kses}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olikohan Bulmassa my-0 joka laittaa y-akselin marginit nolliin 🤔 ei tarvi vaihtaa, aika pieni optimointi, jos tollasta edes oli olemassa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taitaa löytyä my-0, mutta päätin tehdä näin kun copy-pastesin nää muutokset jokaiseen museoteemaankin, niin tää pitää ainakin varmana ettei häviä tyylejä jos jostain sattuu löytymään sivuttais-margineita 🤓
| {/event.normalized.location} | ||
| {/event.normalized.multiple_locations} | ||
|
|
||
| {?event.normalized.multiple_locations} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olisi voinut tehdä vain "if-elsen" eikä ensin "if not" ja sen jälkeen "if"
Severa-ID: 2108
Severa-kuvaus: TMS-1100 Tapahtumaan useampi paikka näkyviin
Task: https://hiondigital.atlassian.net/browse/TMS-1100
Description
Types of changes