TMS-1114: Decrease image-meta paddings

[eebbi]

Severa-ID: 2108
Severa-kuvaus: TMS-1114 Kuvaaja-tiedot näkyviin myös Palstat-komponenttiin
Task: https://hiondigital.atlassian.net/browse/TMS-1114

Description

Decrease image-meta paddings

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[gemini-code-assist]

Hello @eebbi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses the task TMS-1114, which aims to display image metadata, specifically the author, in the Content Columns component. The changes involve adding a 'display_author' field to the ACF fields for Content Columns, modifying the layout template to include the author's name, and adjusting paddings for the image caption. The changes include a new dust template for displaying both image caption and author, and modifications to the existing image-caption template to reduce padding.

Highlights

• Feature Addition: A 'display_author' field is added to the Content Columns component, allowing the display of the image author's name below the image.
• Template Modification: The layout template layout-content-columns.dust is updated to use a new template image-caption-and-author.dust when either the caption or author should be displayed.
• UI Enhancement: The image-caption.dust template is modified to reduce the bottom padding.

Changelog

Click here to see the changelog

• CHANGELOG.MD
  • Added a changelog entry for TMS-1114, noting the addition of the 'display_author' field to the content-columns component.
• lib/ACF/Fields/ContentColumnsFields.php
  • Added a 'display_author' field to the sub_fields array, including label, instructions, and on/off states (lines 82-87).
  • Added a TrueFalse field for 'display_author' with UI settings and instructions (lines 162-169).
  • Included the 'display_author_field' in the array of fields added to the rows_field (line 179).
• partials/layouts/layout-content-columns.dust
  • Modified the conditional to use the image-caption-and-author partial if either display_caption or display_author is set (line 11).
• partials/ui/image/image-caption-and-author.dust
  • Created a new dust template to display both the image caption and author name, with conditional rendering based on the presence of each (lines 1-17).
• partials/ui/image/image-caption.dust
  • Reduced the bottom margin and padding of the caption container (lines 1 and 3).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A field of true or false,
Author's name, no more loss.
Dust template's grace,
Metadata's embrace,
Content columns, across.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new feature to display the author's name under the image in the content columns component. The changes include modifications to the ACF fields, layout templates, and changelog. Overall, the code seems well-structured and addresses the intended functionality.

Merge Readiness

The code changes appear to be well-implemented and address the intended functionality. I did not find any issues at the critical, or high severity levels. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. I recommend merging this pull request.