Skip to content

Fix PHP deprecations #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eebbi merged 1 commit into from
Nov 18, 2025
Merged

Fix PHP deprecations #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

- Fix PHP deprecations

## [1.68.1] - 2025-11-10

- TMS-1204-2: Remove external-link icon for tms.production.geniem.io links
Expand Down
2 changes: 1 addition & 1 deletion lib/ACF/BlogArticleGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ protected function get_authors_tab( string $key ) : Field\Tab {
->set_placement( 'left' );

$authors_field = ( new Field\PostObject( $strings['authors']['title'] ) )
->set_key( "${key}_authors" )
->set_key( "{$key}_authors" )
->set_name( 'authors' )
->set_post_types( [ PostType\BlogAuthor::SLUG ] )
->allow_multiple()
Expand Down
2 changes: 1 addition & 1 deletion lib/ACF/CommentGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ protected function get_author_field( string $key ) : Field\PostObject {
];

return ( new Field\PostObject( $strings['author']['title'] ) )
->set_key( "${key}_author" )
->set_key( "{$key}_author" )
->set_name( 'author' )
->set_post_types( [ PostType\BlogAuthor::SLUG ] )
->allow_null()
Expand Down
10 changes: 5 additions & 5 deletions lib/ACF/DynamicEventGroup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ protected function get_event_tab( string $key ) : ?Field\Tab {
->set_placement( 'left' );

$search_field = ( new Field\Text( $strings['text']['label'] ) )
->set_key( "${key}_text" )
->set_key( "{$key}_text" )
->set_name( 'text' )
->set_wrapper_width( 50 )
->set_instructions( $strings['text']['instructions'] );
Expand All @@ -167,7 +167,7 @@ protected function get_event_tab( string $key ) : ?Field\Tab {
->set_instructions( $strings['category']['instructions'] );

$target_field = ( new Field\Select( $strings['target']['label'] ) )
->set_key( "${key}_target" )
->set_key( "{$key}_target" )
->set_name( 'target' )
->use_ui()
->use_ajax()
Expand All @@ -177,7 +177,7 @@ protected function get_event_tab( string $key ) : ?Field\Tab {
->set_instructions( $strings['target']['instructions'] );

$tag_field = ( new Field\Select( $strings['tag']['label'] ) )
->set_key( "${key}_tag" )
->set_key( "{$key}_tag" )
->set_name( 'tag' )
->use_ui()
->use_ajax()
Expand All @@ -187,7 +187,7 @@ protected function get_event_tab( string $key ) : ?Field\Tab {
->set_instructions( $strings['tag']['instructions'] );

$event_field = ( new Field\Select( $strings['event']['label'] ) )
->set_key( "${key}_event" )
->set_key( "{$key}_event" )
->set_name( 'event' )
->allow_null()
->use_ui()
Expand Down Expand Up @@ -344,7 +344,7 @@ protected function get_components_tab( string $key ) : Field\Tab {
->set_placement( 'left' );

$components_field = ( new Field\FlexibleContent( $strings['components']['title'] ) )
->set_key( "${key}_components" )
->set_key( "{$key}_components" )
->set_name( 'components' )
->set_instructions( $strings['components']['instructions'] );

Expand Down
10 changes: 5 additions & 5 deletions lib/ACF/Fields/AccessibilityIconLinksFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected function sub_fields() : array {
$key = $this->get_key();

$rows_field = ( new Field\Repeater( $strings['rows']['label'] ) )
->set_key( "${key}_rows" )
->set_key( "{$key}_rows" )
->set_name( 'rows' )
->set_min( 2 )
->set_layout( 'block' )
Expand All @@ -79,28 +79,28 @@ protected function sub_fields() : array {
$icons = apply_filters( 'tms/acf/field/' . $key . '_acc_icon/choices', $icons );

$icon_field = ( new Field\Select( $strings['icon']['label'] ) )
->set_key( "${key}_acc_icon" )
->set_key( "{$key}_acc_icon" )
->set_name( 'acc_icon' )
->set_choices( $icons )
->allow_null()
->set_wrapper_width( 50 )
->set_instructions( $strings['icon']['instructions'] );

$title_field = ( new Field\Text( $strings['title']['label'] ) )
->set_key( "${key}_title" )
->set_key( "{$key}_title" )
->set_name( 'title' )
->set_wrapper_width( 50 )
->set_instructions( $strings['title']['instructions'] );

$description_field = ( new Field\Textarea( $strings['description']['label'] ) )
->set_key( "${key}_description" )
->set_key( "{$key}_description" )
->set_name( 'description' )
->set_wrapper_width( 50 )
->set_rows( 2 )
->set_instructions( $strings['description']['instructions'] );

$link_field = ( new Field\Link( $strings['link']['label'] ) )
->set_key( "${key}_link" )
->set_key( "{$key}_link" )
->set_name( 'link' )
->set_wrapper_width( 50 )
->set_instructions( $strings['link']['instructions'] );
Expand Down
14 changes: 7 additions & 7 deletions lib/ACF/Fields/ArticlesFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,13 @@ protected function sub_fields() : array {
$key = $this->get_key();

$title_field = ( new Field\Text( $this->strings['title']['label'] ) )
->set_key( "${key}_title" )
->set_key( "{$key}_title" )
->set_name( 'title' )
->set_wrapper_width( 50 )
->set_instructions( $this->strings['title']['instructions'] );

$description_field = ( new Field\Textarea( $this->strings['description']['label'] ) )
->set_key( "${key}_description" )
->set_key( "{$key}_description" )
->set_name( 'description' )
->set_wrapper_width( 50 )
->set_rows( 4 )
Expand All @@ -153,22 +153,22 @@ protected function sub_fields() : array {
->set_instructions( $this->strings['link']['instructions'] );

$highlight_article_field = ( new Field\PostObject( $this->strings['highlight_article']['label'] ) )
->set_key( "${key}_highlight_article" )
->set_key( "{$key}_highlight_article" )
->set_name( 'highlight_article' )
->set_post_types( [ Post::SLUG ] )
->allow_null()
->set_instructions( $this->strings['highlight_article']['instructions'] );

$display_image_field = ( new Field\TrueFalse( $this->strings['display_image']['label'] ) )
->set_key( "${key}_display_image" )
->set_key( "{$key}_display_image" )
->set_name( 'display_image' )
->set_wrapper_width( 50 )
->set_default_value( true )
->use_ui()
->set_instructions( $this->strings['display_image']['instructions'] );

$feed_type_field = ( new Field\Radio( $this->strings['feed_type']['label'] ) )
->set_key( "${key}_feed_type" )
->set_key( "{$key}_feed_type" )
->set_name( 'feed_type' )
->set_choices( [
'automatic' => $this->strings['feed_type']['type_automatic'],
Expand All @@ -182,15 +182,15 @@ protected function sub_fields() : array {
->add_rule( $feed_type_field, '==', 'manual' );

$category_field = ( new Field\Taxonomy( $this->strings['category']['label'] ) )
->set_key( "${key}_category" )
->set_key( "{$key}_category" )
->set_name( 'category' )
->set_taxonomy( Category::SLUG )
->set_return_format( 'id' )
->set_wrapper_width( 50 )
->set_instructions( $this->strings['category']['instructions'] );

$limit_field = ( new Field\Number( $this->strings['limit']['label'] ) )
->set_key( "${key}_number" )
->set_key( "{$key}_number" )
->set_name( 'number' )
->set_min( 4 )
->set_max( 12 )
Expand Down
14 changes: 7 additions & 7 deletions lib/ACF/Fields/BlogArticlesFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,13 @@ protected function sub_fields() : array {
$key = $this->get_key();

$title_field = ( new Field\Text( $this->strings['title']['label'] ) )
->set_key( "${key}_title" )
->set_key( "{$key}_title" )
->set_name( 'title' )
->set_wrapper_width( 50 )
->set_instructions( $this->strings['title']['instructions'] );

$description_field = ( new Field\Textarea( $this->strings['description']['label'] ) )
->set_key( "${key}_description" )
->set_key( "{$key}_description" )
->set_name( 'description' )
->set_wrapper_width( 50 )
->set_rows( 4 )
Expand All @@ -153,22 +153,22 @@ protected function sub_fields() : array {
->set_instructions( $this->strings['link']['instructions'] );

$highlight_blog_article_field = ( new Field\PostObject( $this->strings['highlight_blog_article']['label'] ) )
->set_key( "${key}_highlight_article" )
->set_key( "{$key}_highlight_article" )
->set_name( 'highlight_article' )
->allow_null()
->set_post_types( [ BlogArticle::SLUG ] )
->set_instructions( $this->strings['highlight_blog_article']['instructions'] );

$display_image_field = ( new Field\TrueFalse( $this->strings['display_image']['label'] ) )
->set_key( "${key}_display_image" )
->set_key( "{$key}_display_image" )
->set_name( 'display_image' )
->set_wrapper_width( 50 )
->set_default_value( true )
->use_ui()
->set_instructions( $this->strings['display_image']['instructions'] );

$feed_type_field = ( new Field\Radio( $this->strings['feed_type']['label'] ) )
->set_key( "${key}_feed_type" )
->set_key( "{$key}_feed_type" )
->set_name( 'feed_type' )
->set_choices( [
'automatic' => $this->strings['feed_type']['type_automatic'],
Expand All @@ -182,15 +182,15 @@ protected function sub_fields() : array {
->add_rule( $feed_type_field, '==', 'manual' );

$category_field = ( new Field\Taxonomy( $this->strings['category']['label'] ) )
->set_key( "${key}_category" )
->set_key( "{$key}_category" )
->set_name( 'category' )
->set_taxonomy( BlogCategory::SLUG )
->set_return_format( 'id' )
->set_wrapper_width( 50 )
->set_instructions( $this->strings['category']['instructions'] );

$limit_field = ( new Field\Number( $this->strings['limit']['label'] ) )
->set_key( "${key}_number" )
->set_key( "{$key}_number" )
->set_name( 'number' )
->set_min( 4 )
->set_max( 12 )
Expand Down
20 changes: 10 additions & 10 deletions lib/ACF/Fields/EventsFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,36 +94,36 @@ protected function sub_fields() : array {
$key = $this->get_key();

$title_field = ( new Field\Text( $strings['title']['label'] ) )
->set_key( "${key}_title" )
->set_key( "{$key}_title" )
->set_name( 'title' )
->set_instructions( $strings['title']['instructions'] );

$start_field = ( new Field\DatePicker( $strings['start']['label'] ) )
->set_key( "${key}_start" )
->set_key( "{$key}_start" )
->set_name( 'start' )
->set_display_format( 'j.n.Y' )
->set_return_format( 'Y-m-d' )
->set_wrapper_width( 50 )
->set_instructions( $strings['start']['instructions'] );

$end_field = ( new Field\DatePicker( $strings['end']['label'] ) )
->set_key( "${key}_end" )
->set_key( "{$key}_end" )
->set_name( 'end' )
->set_display_format( 'j.n.Y' )
->set_return_format( 'Y-m-d' )
->set_wrapper_width( 50 )
->set_instructions( $strings['end']['instructions'] );

$starts_today_field = ( new Field\TrueFalse( $strings['starts_today']['label'] ) )
->set_key( "${key}_starts_today" )
->set_key( "{$key}_starts_today" )
->set_name( 'starts_today' )
->use_ui()
->set_default_value( false )
->set_wrapper_width( 50 )
->set_instructions( $strings['starts_today']['instructions'] );

$category_field = ( new Field\Select( $strings['category']['label'] ) )
->set_key( "${key}_category" )
->set_key( "{$key}_category" )
->set_name( 'category' )
->use_ui()
->use_ajax()
Expand All @@ -133,7 +133,7 @@ protected function sub_fields() : array {
->set_instructions( $strings['category']['instructions'] );

$area_field = ( new Field\Select( $strings['area']['label'] ) )
->set_key( "${key}_area" )
->set_key( "{$key}_area" )
->set_name( 'area' )
->use_ui()
->allow_null()
Expand Down Expand Up @@ -163,13 +163,13 @@ protected function sub_fields() : array {
->set_instructions( $strings['tag']['instructions'] );

$text_field = ( new Field\Text( $strings['text']['label'] ) )
->set_key( "${key}_text" )
->set_key( "{$key}_text" )
->set_name( 'text' )
->set_wrapper_width( 50 )
->set_instructions( $strings['text']['instructions'] );

$page_size_field = ( new Field\Number( $strings['page_size']['label'] ) )
->set_key( "${key}_page_size" )
->set_key( "{$key}_page_size" )
->set_name( 'page_size' )
->set_min( 3 )
->set_max( 12 )
Expand All @@ -178,15 +178,15 @@ protected function sub_fields() : array {
->set_instructions( $strings['page_size']['instructions'] );

$show_images_field = ( new Field\TrueFalse( $strings['show_images']['label'] ) )
->set_key( "${key}_show_images" )
->set_key( "{$key}_show_images" )
->set_name( 'show_images' )
->use_ui()
->set_default_value( true )
->set_wrapper_width( 50 )
->set_instructions( $strings['show_images']['instructions'] );

$all_events_link_field = ( new Field\Link( $strings['all_events_link']['label'] ) )
->set_key( "${key}_all_events_link" )
->set_key( "{$key}_all_events_link" )
->set_name( 'all_events_link' )
->set_wrapper_width( 50 )
->set_instructions( $strings['all_events_link']['instructions'] );
Expand Down
2 changes: 1 addition & 1 deletion lib/ACF/Fields/GravityFormFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ protected function sub_fields() : array {
$key = $this->get_key();

$field = ( new Field\GravityForms( $strings['text']['label'] ) )
->set_key( "${key}_form" )
->set_key( "{$key}_form" )
->set_name( 'form' )
->set_required()
->set_instructions( $strings['text']['instructions'] );
Expand Down
10 changes: 5 additions & 5 deletions lib/ACF/Fields/IconLinksFields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ protected function sub_fields() : array {
$key = $this->get_key();

$rows_field = ( new Field\Repeater( $strings['rows']['label'] ) )
->set_key( "${key}_rows" )
->set_key( "{$key}_rows" )
->set_name( 'rows' )
->set_min( 3 )
->set_max( 9 )
Expand All @@ -80,28 +80,28 @@ protected function sub_fields() : array {
$icons = apply_filters( 'tms/acf/field/' . $key . '_icon/choices', $icons );

$icon_field = ( new Field\Select( $strings['icon']['label'] ) )
->set_key( "${key}_icon" )
->set_key( "{$key}_icon" )
->set_name( 'icon' )
->set_choices( $icons )
->allow_null()
->set_wrapper_width( 50 )
->set_instructions( $strings['icon']['instructions'] );

$title_field = ( new Field\Text( $strings['title']['label'] ) )
->set_key( "${key}_title" )
->set_key( "{$key}_title" )
->set_name( 'title' )
->set_wrapper_width( 50 )
->set_instructions( $strings['title']['instructions'] );

$description_field = ( new Field\Textarea( $strings['description']['label'] ) )
->set_key( "${key}_description" )
->set_key( "{$key}_description" )
->set_name( 'description' )
->set_wrapper_width( 50 )
->set_rows( 2 )
->set_instructions( $strings['description']['instructions'] );

$link_field = ( new Field\Link( $strings['link']['label'] ) )
->set_key( "${key}_link" )
->set_key( "{$key}_link" )
->set_name( 'link' )
->set_wrapper_width( 50 )
->set_instructions( $strings['link']['instructions'] );
Expand Down
Loading
Loading