TMS-1173: Add hero-layout for blog-article archive & blog-category taxonomy archive #200
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @eebbi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new hero layouts for blog article archives and blog category taxonomy archives, significantly enhancing the visual presentation of these pages. It also adds a dedicated hero image field for blog categories, allowing for more customizable and engaging archive pages.
Highlights
- New ACF Field Group for Blog Categories: A new ACF field group (BlogCategoryGroup.php) has been introduced to allow administrators to upload a "hero image" for blog categories. This image will be used on the blog category listing pages.
- Archive Model Enhancements: The archive.php model now includes methods to retrieve the page description and the newly added blog category hero image ID, making this data available to the frontend templates.
- Blog Article Archive Hero Layout: The archive-blog-article.dust template has been updated to support a new hero layout. If a page_logo is present, a full-width hero section with the title and subtitle is displayed. Otherwise, the title, subtitle, and description are shown in a standard layout.
- Blog Category Archive Hero Layout: The archive-inner.dust template now conditionally renders a hero section for blog category archives. If a blog_category_image is available, it will be used as a background for a hero section displaying the category title and description. If no image is present, the title and description are displayed in a standard layout.
- Output Filtering Updates: Throughout the .dust templates, the output filters have been updated from |s (strip_tags) to |html or |kses for better handling of HTML content, ensuring proper rendering and security.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a hero layout for blog article archives and blog category taxonomy archives. It also adds a hero image field for blog categories. The changes are well-implemented, adding new ACF fields, updating the data models, and modifying the templates. I've found a minor issue in the archive.php model regarding a function's return type documentation and declaration, which I've commented on. Otherwise, the code looks good and the use of Dust.js filters has been improved for better security.
Severa-ID: 2132
Severa-kuvaus: TMS-1173 Blogilistaussivulle hero ja johdanto
Task: https://hiondigital.atlassian.net/browse/TMS-1173
Description
Types of changes