fix: Fixing races and resouce leaks#168
Closed
tantra35 wants to merge 0 commit intodevgianlu:masterfrom
Closed
Conversation
devgianlu
requested changes
Jul 12, 2025
spclient/spclient.go
Outdated
Comment on lines
65
to
66
| for name, values := range header { | ||
| req.Header[name] = values |
Contributor
Author
There was a problem hiding this comment.
Reason is simple, condition here is not needed, due range over nil map is acceptable, and means just skip loop
cmd/daemon/player.go
Outdated
| func (p *AppPlayer) Run(ctx context.Context, apiRecv <-chan ApiRequest) { | ||
| err := p.sess.Dealer().Connect(ctx) | ||
| func (p *AppPlayer) Run(_ctx context.Context, apiRecv <-chan ApiRequest) { | ||
| runCtx, cancelFn := context.WithCancel(_ctx) |
Owner
There was a problem hiding this comment.
Use ctx, cancel as per standard practice
tantra35
force-pushed
the
fix-01-portion-of-sync-bugs
branch
2 times, most recently
from
c482dfc to
1a95e0b
Compare
tantra35
force-pushed
the
fix-01-portion-of-sync-bugs
branch
from
1a95e0b to
57ffceb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must provide some cancelable context, so when main applplayer loop ends, any depend network operations must be canceled
When chanel is closed it return empty variables (in case none pointer it returns emptry structs, wil nil chanel and if we do ch recive o send "some data" to nil chanel we hang forever)
chanel for stop must be simple closed, in such case when we do <- closedCh we will signal in any case wneh chanel closed
Dealer must be closed at the end on player loop