fix: validate required 'log' key during HAR deserialization#156
Merged
deviantintegral merged 1 commit intomainfrom Dec 16, 2025
Merged
fix: validate required 'log' key during HAR deserialization#156deviantintegral merged 1 commit intomainfrom
deviantintegral merged 1 commit intomainfrom
Conversation
Add PostDeserialize validation to ensure HAR files contain the required 'log' key. Previously, missing 'log' keys would cause uninitialized property errors when accessing getLog(). Now, deserializeHar() properly throws JMS\Serializer\Exception\RuntimeException with a clear message. Changes: - Add PostDeserialize annotation to Har::validateLogProperty() - Add MissingLogKeyTest with tests for missing/invalid log keys - Fix 18_bom.har fixture to be a valid minimal HAR file with BOM - Add missing-log.har test fixture for edge case testing The solution uses JMS Serializer's PostDeserialize annotation instead of manual JSON parsing, keeping the validation logic within the domain model.
Owner
Author
|
I confirmed the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PostDeserialize validation to ensure HAR files contain the required 'log' key. Previously, missing 'log' keys would cause uninitialized property errors when accessing getLog(). Now, deserializeHar() properly throws JMS\Serializer\Exception\RuntimeException with a clear message.
Changes:
The solution uses JMS Serializer's PostDeserialize annotation instead of manual JSON parsing, keeping the validation logic within the domain model.