test: add immutability tests for CloneRemoval mutations#160
Merged
deviantintegral merged 2 commits intomainfrom Dec 17, 2025
Merged
test: add immutability tests for CloneRemoval mutations#160deviantintegral merged 2 commits intomainfrom
deviantintegral merged 2 commits intomainfrom
Conversation
Added comprehensive tests to ensure that PSR-7 with* methods properly clone underlying objects and maintain immutability: - Request: withHeader, withoutHeader, withAddedHeader, withRequestTarget, withMethod, withUri, withBody, getHarRequest, constructor - Response: withStatus, withBody, getHarResponse - ServerRequest: withCookieParams, withQueryParams, withParsedBody Also added phpunit.xml without external XSD schema reference to avoid network dependency issues during testing. These tests ensure that calling with* methods returns new instances and doesn't modify the original object, which is critical for PSR-7 immutability requirements.
Added tests to verify that methods returning arrays properly return all items, not just a single item: - ServerRequest.getCookieParams: Test with multiple cookies - ServerRequest.getQueryParams: Test with multiple query parameters These tests ensure that array mutation testing catches cases where array methods might incorrectly return only one item. Also added infection artifacts to .gitignore.
188ebec to
546cd54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to ensure that PSR-7 with* methods properly clone underlying objects and maintain immutability.