test: remove redundant assertions in Adapter/Psr7/RequestTest #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
force-pushed
the
claude/remove-duplicate-tests-7kyGR
branch
from
93e36df to
e831d5f
Compare
Remove 7 redundant assertions that are logically implied by other tests:
- testHasHeaderCaseInsensitive: Remove hasHeader('Accept') check
(already tested in testHasHeader)
- testWithUriPreservesHostWhenRequested: Remove assertNotEquals check
(implied by assertEquals with original host)
- testWithoutHeaderCaseInsensitive: Remove 3 variant case checks
(hasHeader case-insensitivity tested elsewhere)
- testWithHeaderDoesNotModifyOriginal: Remove hasHeader('X-Test') check
(implied by assertEquals with originalHeaders)
- testGetBody: Remove assertInstanceOf check
(implied by successful string cast of stream)
All removals verified with:
- Tests still pass
- Coverage unchanged (97.73%)
- Infection MSI maintained at 100%
deviantintegral
force-pushed
the
claude/remove-duplicate-tests-7kyGR
branch
from
e831d5f to
5ca3816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 7 redundant assertions that are logically implied by other tests:
All removals verified with: