Useful extensions #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 29, 2016 14:53
…independent of the date.
…ltiple chains per day.
Owner
|
Thanks for the PR ! Sorry for the late review, could you update the description of this PR with more details please? I'm not sure I totally understand the point of it. I've seen that you introduce a new option, could you also update the README? I'm also searching for maintainers for this project, see #40, tell me if you'd be interested :) |
deviantony
requested changes
Sep 23, 2016
| files = glob(''.join([directory, '/', prefix, '*'])) | ||
| return files[0] | ||
|
|
||
| def get_prefixed_files_in_dir(directory, prefix): |
Owner
There was a problem hiding this comment.
Looks like duplicated code to me. Just define get_prefixed_files_in_dir and remove the first one. Then update the function call in
backup_archive = filesystem_utils.get_prefixed_file_in_dir( archive_repository, prefix)[0]
| --uncompressed-archives \ | ||
| Specify that the backup archives are not compressed. \ | ||
| Use this option if you did backup with --no-compress. | ||
| --without-stop-mysql \ |
Owner
There was a problem hiding this comment.
This should be added in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to restore a backup, all incremental should be in the same directory than the base backup. Only backups of one backup chain should be in one directory, also if there are multiple chains per day.