Skip to content

Pass name of service to stop/start as an optional argument #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wndhydrnt wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Pass name of service to stop/start as an optional argument #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions xtrabackup/restoration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
[--log-file=<log>] \
[--out-file=<log>] \
[--backup-threads=<threads>] \
[--uncompressed-archives]
[--uncompressed-archives] \
[--service-name=<name>]
pyxtrabackup-restore (-h | --help)
pyxtrabackup --version

Expand Down Expand Up @@ -44,6 +45,8 @@
--uncompressed-archives \
Specify that the backup archives are not compressed. \
Use this option if you did backup with --no-compress.
--service-name=<name> \
Name of the mysql service to stop/start [default: mysql].

"""
from docopt import docopt
Expand All @@ -57,7 +60,8 @@ def main():
restore_tool = RestorationTool(arguments['--log-file'],
arguments['--out-file'],
arguments['--data-dir'],
arguments['--uncompressed-archives'])
arguments['--uncompressed-archives'],
arguments['--service-name'])
try:
restore_tool.start_restoration(arguments['--base-archive'],
arguments['--incremental-archive'],
Expand Down
7 changes: 4 additions & 3 deletions xtrabackup/restoration_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,14 @@

class RestorationTool:

def __init__(self, log_file, output_file, data_dir, uncompressed_archives):
def __init__(self, log_file, output_file, data_dir, uncompressed_archives, service_name):
self.log_manager = log_manager.LogManager()
self.data_dir = data_dir
self.stop_watch = timer.Timer()
self.setup_logging(log_file)
self.command_executor = CommandExecutor(output_file)
self.compressed_archives = not uncompressed_archives
self.service_name = service_name

def setup_logging(self, log_file):
self.logger = logging.getLogger(__name__)
Expand All @@ -27,7 +28,7 @@ def prepare_workdir(self, path):

def stop_service(self):
try:
self.command_executor.exec_manage_service('mysql', 'stop')
self.command_executor.exec_manage_service(self.service_name, 'stop')
except:
self.logger.error(
'Unable to manage MySQL service.',
Expand Down Expand Up @@ -128,7 +129,7 @@ def set_data_dir_permissions(self):

def start_service(self):
try:
self.command_executor.exec_manage_service('mysql', 'start')
self.command_executor.exec_manage_service(self.service_name, 'start')
except:
self.logger.error(
'Unable to manage MySQL service.',
Expand Down