Skip to content

Commit 5b0b7d8

Browse files
riglarclaude
andcommitted
Remove x86-arch feature for iOS
This removes the x86-arch parameter as it's no longer needed for iOS testing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent e5aeea1 commit 5b0b7d8

File tree

5 files changed

+2
-26
lines changed

5 files changed

+2
-26
lines changed

README.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
app-file: app/build/outputs/apk/debug/app-debug.apk
5555
```
5656

57-
`app-file` should point to an x86 compatible APK file, either directly to the file or a glob pattern matching the file name. When using a pattern, the first matched file will be used.
57+
`app-file` should point to an APK file, either directly to the file or a glob pattern matching the file name. When using a pattern, the first matched file will be used.
5858

5959
# iOS
6060

@@ -320,18 +320,6 @@ For Android tests, you can run your flows against Google Play devices:
320320
google-play: true
321321
```
322322

323-
# x86 Architecture (iOS)
324-
325-
For iOS tests, you can run your flows against x86 architecture simulators instead of arm64 (experimental):
326-
327-
```yaml
328-
- uses: devicecloud-dev/device-cloud-for-maestro@v1
329-
with:
330-
api-key: ${{ secrets.DCD_API_KEY }}
331-
app-file: app.zip
332-
x86-arch: true
333-
```
334-
335323
# Runner Types (Experimental)
336324

337325
You can specify a custom runner type using the `runner-type` parameter:
@@ -465,7 +453,6 @@ Here's a complete example showing all available options:
465453
device-locale: en_US # ISO-639-1_ISO-3166-1
466454
orientation: 0 # 0|90|180|270 (Android only)
467455
google-play: false # Use Google Play devices (Android)
468-
x86-arch: false # Use x86 architecture (iOS)
469456
470457
# Flow Configuration
471458
flows: myFlows/ # or workspace: myFlows/ (flows takes precedence)

action.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ inputs:
9090
description: 'The path to the workspace folder containing your flows'
9191
required: false
9292
default: './.maestro/'
93-
x86-arch:
94-
description: '[iOS only, experimental] Run your flow against x86 architecture simulator instead of arm64'
95-
required: false
9693
config:
9794
description: 'Specific path to your maestro config file'
9895
required: false

dist/index.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29995,7 +29995,7 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
2999529995
var _a;
2999629996
try {
2999729997
const dcdVersionString = yield getLatestDcdVersion();
29998-
const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, x86Arch, runnerType, debug, moropoV1ApiKey, } = yield (0, params_1.getParameters)();
29998+
const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, runnerType, debug, moropoV1ApiKey, } = yield (0, params_1.getParameters)();
2999929999
const params = {
3000030000
'additional-app-binary-ids': additionalAppBinaryIds,
3000130001
'additional-app-files': additionalAppFiles,
@@ -30022,7 +30022,6 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
3002230022
orientation,
3002330023
report,
3002430024
retry,
30025-
'x86-arch': x86Arch,
3002630025
'runner-type': runnerType,
3002730026
'json-file': jsonFile,
3002830027
debug,
@@ -30253,7 +30252,6 @@ function getParameters() {
3025330252
if (report && report !== 'junit' && report !== 'html') {
3025430253
throw new Error('Report format must be either "junit" or "html"');
3025530254
}
30256-
const x86Arch = core.getInput('x86-arch', { required: false }) === 'true';
3025730255
const config = core.getInput('config', { required: false });
3025830256
const runnerType = core.getInput('runner-type', { required: false });
3025930257
const jsonFile = core.getInput('json-file', { required: false }) === 'true';
@@ -30294,7 +30292,6 @@ function getParameters() {
3029430292
retry,
3029530293
ignoreShaCheck,
3029630294
report,
30297-
x86Arch,
3029830295
config,
3029930296
runnerType,
3030030297
jsonFile,

src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ const run = async (): Promise<void> => {
125125
report,
126126
retry,
127127
workspaceFolder,
128-
x86Arch,
129128
runnerType,
130129
debug,
131130
moropoV1ApiKey,
@@ -157,7 +156,6 @@ const run = async (): Promise<void> => {
157156
orientation,
158157
report,
159158
retry,
160-
'x86-arch': x86Arch,
161159
'runner-type': runnerType,
162160
'json-file': jsonFile,
163161
debug,

src/methods/params.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ export type Params = {
2727
retry?: number;
2828
ignoreShaCheck?: boolean;
2929
report?: 'junit' | 'html';
30-
x86Arch?: boolean;
3130
config?: string;
3231
runnerType?: string;
3332
jsonFile?: boolean;
@@ -175,7 +174,6 @@ export async function getParameters(): Promise<Params> {
175174
throw new Error('Report format must be either "junit" or "html"');
176175
}
177176

178-
const x86Arch = core.getInput('x86-arch', { required: false }) === 'true';
179177
const config = core.getInput('config', { required: false });
180178
const runnerType = core.getInput('runner-type', { required: false });
181179
const jsonFile = core.getInput('json-file', { required: false }) === 'true';
@@ -222,7 +220,6 @@ export async function getParameters(): Promise<Params> {
222220
retry,
223221
ignoreShaCheck,
224222
report,
225-
x86Arch,
226223
config,
227224
runnerType,
228225
jsonFile,

0 commit comments

Comments
 (0)