Skip to content

Conversation

@Nexabra
Copy link
Contributor

@Nexabra Nexabra commented Dec 7, 2023

Add the necessary requirements to allow the creation of the API

Genesis Unveiled: Project Inception 🌌

@Nexabra Nexabra self-assigned this Dec 7, 2023
@Nexabra Nexabra marked this pull request as ready for review December 8, 2023 03:19
@Nexabra Nexabra requested a review from zefir-git December 8, 2023 03:19
Copy link
Contributor

@zefir-git zefir-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request appears incomplete

@zefir-git zefir-git marked this pull request as draft December 8, 2023 04:53
@Nexabra Nexabra marked this pull request as ready for review December 9, 2023 02:35
@Nexabra
Copy link
Contributor Author

Nexabra commented Dec 9, 2023

Extensive demo of the features that have been added
https://streamable.com/9d8vjr

@Nexabra Nexabra requested a review from zefir-git December 9, 2023 02:47
@Nexabra
Copy link
Contributor Author

Nexabra commented Dec 9, 2023

Possible idea for you to add to the review @zefir-git

We could have a Connector class, and that class will define whether the connector is an external (port) or internal connector. The class will have the type of connector (ex. thunderbolt) and the version as a number (ex. 4). This will also show what components can be removed and what types of components said connector supports. An internal example of this class would be storing a SATA III connector as an internal connector

All these connectors will be stored as Connector[] in the Laptop class. It will also be useful for showing microSD and port selection on the future phone class

I don't know how to form this exactly or what this class should have, so please give me some input

public readonly architecture: string;
public readonly graphics: string | null;
public readonly cores: CPU.Core[];
// CPU Cache in kilobytes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should put jsdoc like so on everything. We can later generate docs for the entire project from that

Suggested change
// CPU Cache in kilobytes
/**
* CPU cache in KB
*/

@Nissoco23 Nissoco23 assigned Nissoco23 and unassigned Nexabra Dec 18, 2023
@Nissoco23 Nissoco23 requested a review from zefir-git December 19, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add various hardware classes, including Cpu, Ram, Laptop, and Phone classes

4 participants