-
Notifications
You must be signed in to change notification settings - Fork 2.4k
update icon: amazonwebservices (original, plain, line) #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release v2.17.0
|
@canaleal @ReenigneArcher @weh Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!
Thank you for your contribution and detailed description which made this much faster for me to review!
LGTM ✅
EDIT:
Guess I was too fast, there are a few small issues here, but no big deal, I fixed them for you.
For future reference though, the issues were:
- base branch was master instead of develop
- you didn't follow the PR template for new/updated icons by adding
?quick_pull=1&template=new_icon.md&labels=feature:iconto the end of your PR URL - wrong format on closing issue text. It should be: "This PR closes #
- name of PR was wrong (part of template in 2.)
|
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem. Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
|
Thanks for the assist @Snailedlt 🚀 |
|
@canaleal @lunatic-fox @ConX @weh @ReenigneArcher Could I get a review please? |
weh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to add here 👍
|
Could we merge up? @weh @ReenigneArcher @Snailedlt |








Double check these details before you open a PR
Features
iconsarrayaws/amazonwebservices- the reason for this is that AWS uses the suffix-wordmarkfor each of the 3 icons and is inconsistent with the naming from other icons (word mark is understandably the default as there is no other icon for AWS)Fix
Option 1
-wordmarksuffix to remove it and make it consistent with other icons.Option 2
-wordmarksuffix, preciselyamazonwebservices-originalamazonwebservices-original-wordmark**This PR closes #1703
Notes