Skip to content

Conversation

@bhaumikmaan
Copy link

@bhaumikmaan bhaumikmaan commented Aug 11, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • I was working on a personal project where I was using devicon and came across one singular inconsistency from 25+ icons I had in the icons array
Screenshot 2025-08-11 at 16 24 15
  • This icon was aws/amazonwebservices - the reason for this is that AWS uses the suffix -wordmark for each of the 3 icons and is inconsistent with the naming from other icons (word mark is understandably the default as there is no other icon for AWS)
  • So I looked for fixes/previously opened issues and came across open [BUG] amazonwebservices inconsistent version names #1703

Fix

Option 1

  • We rename the existing -wordmark suffix to remove it and make it consistent with other icons.
  • We will employ aliases to handle no breaking changes for the existing usage of the icon

Option 2

  • We add a new duplicate icon without the -wordmark suffix, precisely amazonwebservices-original
  • This will ensure consistency along with no risk of breaking the existing implementation of amazonwebservices-original-wordmark

**This PR closes #1703

Notes

  1. Needs proper checks because if the change break, it could hamper all existing usage of the AWS Icon

@bhaumikmaan
Copy link
Author

@canaleal @ReenigneArcher @weh Please review

Snailedlt
Snailedlt previously approved these changes Aug 11, 2025
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!
Thank you for your contribution and detailed description which made this much faster for me to review!

LGTM ✅

EDIT:
Guess I was too fast, there are a few small issues here, but no big deal, I fixed them for you.
For future reference though, the issues were:

  1. base branch was master instead of develop
  2. you didn't follow the PR template for new/updated icons by adding ?quick_pull=1&template=new_icon.md&labels=feature:icon to the end of your PR URL
  3. wrong format on closing issue text. It should be: "This PR closes #
  4. name of PR was wrong (part of template in 2.)

@Snailedlt Snailedlt changed the base branch from master to develop August 11, 2025 20:52
@Snailedlt Snailedlt dismissed their stale review August 11, 2025 20:52

The base branch was changed.

@Snailedlt Snailedlt changed the title Fixing AWS Inconsistency update icon: aws (original, plain, line) Aug 11, 2025
@Snailedlt Snailedlt added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Aug 11, 2025
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'update icon: aws (original, plain, line)'

Make sure that:

  • Your SVGs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@Snailedlt Snailedlt changed the title update icon: aws (original, plain, line) update icon: amazonwebservices (original, plain, line) Aug 11, 2025
@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Aug 11, 2025
@Snailedlt Snailedlt closed this Aug 11, 2025
@Snailedlt Snailedlt reopened this Aug 11, 2025
@Snailedlt Snailedlt added bot:check Trigger check-bot. Remove and re-add the label to re-trigger and removed bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Aug 11, 2025
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@Snailedlt Snailedlt requested review from a team, ConX, ReenigneArcher and weh and removed request for a team August 11, 2025 21:30
@bhaumikmaan
Copy link
Author

Thanks for the assist @Snailedlt 🚀

@bhaumikmaan
Copy link
Author

@canaleal @lunatic-fox @ConX @weh @ReenigneArcher Could I get a review please?

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to add here 👍

@bhaumikmaan
Copy link
Author

Could we merge up? @weh @ReenigneArcher @Snailedlt

@Snailedlt Snailedlt merged commit 508c963 into devicons:develop Aug 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants