api: Fix SparseFunction distributor setup#2739
Conversation
cff361e to
746caf6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2739 +/- ##
==========================================
- Coverage 82.96% 82.95% -0.01%
==========================================
Files 248 248
Lines 50133 50152 +19
Branches 4415 4417 +2
==========================================
+ Hits 41592 41606 +14
- Misses 7787 7790 +3
- Partials 754 756 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ee89ea1 to
ce3e1e1
Compare
|
|
||
| # Performance profiling | ||
|
|
||
| def _emit_args_profiling(self, tag=''): |
There was a problem hiding this comment.
honestly I would aggregate everything inside _emit_apply_profiling. I think what you're doing here is very important so I'd try to get it "ideal" from the get go. How about something along these lines? I'd certainly find it a bit less verbose and easily extensible
Operator XXX ran in ....
Global performance ...
Global performance w/o setup
Excluded Python-level overheads: 2.2 s [1.5 s args pre-proc, 0.5 s args post-proc]
Either "Excluded" or "Additional" or perhaps just nothing...
Anyway, food for thought
There was a problem hiding this comment.
I like it separate, it makes it easier to find/parse for the user and it's a python time vs the "c-land" time so i feel it's beeter as separate entry.
404cabe to
a18d135
Compare
a18d135 to
ab95dc6
Compare
api: Fix SparseFunction distributor setup
api: Fix SparseFunction distributor setup
api: Fix SparseFunction distributor setup
api: Fix SparseFunction distributor setup
No description provided.