fix: move imports to top-level in test file #1

devjerry0 · 2025-12-12T16:49:14Z

Fixed PLC0415 ruff errors (imports inside functions)
Moved pytest, os, and tempfile imports to module top
All 16 tests still passing
Ruff and mypy clean

- Fixed PLC0415 ruff errors (imports inside functions) - Moved pytest, os, and tempfile imports to module top - All 16 tests still passing - Ruff and mypy clean

- Upgraded codecov/codecov-action from v4 to v5 - Added CODECOV_TOKEN secret reference (required for v5) - Need to add token in GitHub repo settings before merge

- Trigger on push to dev and main branches only - Trigger on pull requests to main - Prevents unnecessary CI runs on other branches

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- First release of sane-contractions fork - Uses semantic versioning: 0.2.0 signals new features with API evolution room - Follows Python community conventions for new packages

- Only publish from main/master branch - Run full test suite before publishing - Require manual confirmation for workflow_dispatch - Added test job that must pass before deploy - Prevents accidental publishes from dev branches

- Cancel in-progress CI runs when new commits are pushed - Saves CI resources and provides faster feedback - Publish workflow doesn't cancel (safety measure) - Groups by workflow name and git ref

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

setup.py

pyproject.toml

contractions/__init__.py

setup.py

- Created contractions/_version.py with version constant - All files now read from this single source - setup.py dynamically reads version from _version.py - pyproject.toml uses setuptools dynamic version - __init__.py imports from _version To update version: just edit contractions/_version.py

- Created contractions/_version.py as single version source - Simplified setup.py to minimal config (removed duplicates) - All metadata now in pyproject.toml (PEP 621 standard) - Fixed setuptools license classifier conflicts - Excluded tests from wheel distribution - Version is now changed in ONE place only To bump version: just edit contractions/_version.py

- Added coverage.xml (generated by pytest-cov) - Added htmlcov/ (coverage HTML reports) - Added .pytest_cache/ (pytest cache) - Added *.egg-info/ (build artifacts)

- Added .mypy_cache/ (mypy type checker cache) - Added .ruff_cache/ (ruff linter cache) - Added .dmypy.json, dmypy.json (mypy daemon) - Added .hypothesis/ (hypothesis testing cache)

- Deleted UV_USAGE.md (overkill for separate file) - Main README already covers uv installation - Cleaned up reference in README

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:88

This version update logic references MAJOR_VERSION, MINOR_VERSION, and MICRO_VERSION variables that no longer exist in the refactored setup.py. The new setup.py reads the version from contractions/_version.py instead. This script will fail with grep errors when trying to extract these variables. The version update logic needs to be refactored to update the contractions/_version.py file instead of trying to modify setup.py variables.

      - name: Update version from git commits
        run: |
          COMMIT_COUNT=$(git rev-list --all --count)
          MAJOR=$(grep 'MAJOR_VERSION = ' setup.py | sed 's/.*"\([0-9]*\)".*/\1/')
          MINOR=$(grep 'MINOR_VERSION = ' setup.py | sed 's/.*"\([0-9]*\)".*/\1/')
          VERSION="${MAJOR}.${MINOR}.${COMMIT_COUNT}"
          
          sed -i "s/MICRO_VERSION = \"[0-9]*\"/MICRO_VERSION = \"${COMMIT_COUNT}\"/" setup.py
          sed -i "s/__version__ = \"[0-9.]*\"/__version__ = \"${VERSION}\"/" contractions/__init__.py
          
          echo "Building version: ${VERSION}"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

setup.py

setuptools automatically reads version from pyproject.toml's tool.setuptools.dynamic.version configuration. Manual regex parsing was unnecessary duplication.

Version is now managed in contractions/_version.py as single source

Now publishing is simple: git tag v0.2.0 git push --tags Workflow automatically: - Extracts version from tag - Updates _version.py - Builds package - Publishes to PyPI

Workflow: 1. Edit contractions/_version.py (e.g., 0.2.0 → 0.3.0) 2. Merge to main 3. Auto-creates tag v0.3.0 4. Tag triggers publish workflow 5. Package auto-publishes to PyPI No manual tagging needed!

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/commit.yml

README.md

pyproject.toml

github-advanced-security · 2025-12-12T17:32:12Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Fixes CodeQL security warnings by limiting token permissions: - commit.yml: contents: read (only needs to read code) - publish.yml: contents: read + id-token: write (for PyPI publishing) This follows security best practices by using least privilege principle.

codecov-commenter · 2025-12-12T17:45:30Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

fix: move imports to top-level in test file

1b31c83

- Fixed PLC0415 ruff errors (imports inside functions) - Moved pytest, os, and tempfile imports to module top - All 16 tests still passing - Ruff and mypy clean

Copilot AI review requested due to automatic review settings December 12, 2025 16:49

devjerry0 added 2 commits December 12, 2025 11:52

chore: update codecov action to v5 with token

860832a

- Upgraded codecov/codecov-action from v4 to v5 - Added CODECOV_TOKEN secret reference (required for v5) - Need to add token in GitHub repo settings before merge

chore: configure workflow triggers for dev and main branches

8ca1e91

- Trigger on push to dev and main branches only - Trigger on pull requests to main - Prevents unnecessary CI runs on other branches

Copilot AI reviewed Dec 12, 2025

View reviewed changes

devjerry0 requested a review from Copilot December 12, 2025 17:04

Copilot started reviewing on behalf of devjerry0 December 12, 2025 17:05 View session

Copilot AI reviewed Dec 12, 2025

View reviewed changes

devjerry0 added 2 commits December 12, 2025 12:07

chore: set version to 0.2.0 for initial fork release

bbb334b

- First release of sane-contractions fork - Uses semantic versioning: 0.2.0 signals new features with API evolution room - Follows Python community conventions for new packages

feat: add safety checks to publish workflow

b5dc943

- Only publish from main/master branch - Run full test suite before publishing - Require manual confirmation for workflow_dispatch - Added test job that must pass before deploy - Prevents accidental publishes from dev branches

Copilot AI review requested due to automatic review settings December 12, 2025 17:08

Copilot started reviewing on behalf of devjerry0 December 12, 2025 17:08 View session

feat: add concurrency controls to workflows

ebe1968

- Cancel in-progress CI runs when new commits are pushed - Saves CI resources and provides faster feedback - Publish workflow doesn't cancel (safety measure) - Groups by workflow name and git ref

Copilot AI reviewed Dec 12, 2025

View reviewed changes

setup.py Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

contractions/__init__.py Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

devjerry0 added 2 commits December 12, 2025 12:15

Copilot AI review requested due to automatic review settings December 12, 2025 17:17

chore: add coverage and build artifacts to gitignore

b042dc7

- Added coverage.xml (generated by pytest-cov) - Added htmlcov/ (coverage HTML reports) - Added .pytest_cache/ (pytest cache) - Added *.egg-info/ (build artifacts)

Copilot started reviewing on behalf of devjerry0 December 12, 2025 17:17 View session

devjerry0 added 2 commits December 12, 2025 12:18

chore: add tool caches to gitignore

ba067c9

- Added .mypy_cache/ (mypy type checker cache) - Added .ruff_cache/ (ruff linter cache) - Added .dmypy.json, dmypy.json (mypy daemon) - Added .hypothesis/ (hypothesis testing cache)

chore: remove unnecessary UV_USAGE.md

9eabe56

- Deleted UV_USAGE.md (overkill for separate file) - Main README already covers uv installation - Cleaned up reference in README

Copilot AI reviewed Dec 12, 2025

View reviewed changes

setup.py Outdated Show resolved Hide resolved

devjerry0 added 2 commits December 12, 2025 12:21

refactor: remove redundant version parsing from setup.py

0cb1327

setuptools automatically reads version from pyproject.toml's tool.setuptools.dynamic.version configuration. Manual regex parsing was unnecessary duplication.

fix: remove broken version update step from publish workflow

505c7b1

Version is now managed in contractions/_version.py as single source

Copilot AI review requested due to automatic review settings December 12, 2025 17:23

Copilot started reviewing on behalf of devjerry0 December 12, 2025 17:23 View session

devjerry0 added 2 commits December 12, 2025 12:25

feat: auto-publish on git tag push

5f87340

Now publishing is simple: git tag v0.2.0 git push --tags Workflow automatically: - Extracts version from tag - Updates _version.py - Builds package - Publishes to PyPI

feat: auto-create git tags on version bump

cb5679b

Workflow: 1. Edit contractions/_version.py (e.g., 0.2.0 → 0.3.0) 2. Merge to main 3. Auto-creates tag v0.3.0 4. Tag triggers publish workflow 5. Package auto-publishes to PyPI No manual tagging needed!

Copilot AI reviewed Dec 12, 2025

View reviewed changes

.github/workflows/commit.yml Show resolved Hide resolved

README.md Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

devjerry0 merged commit c89e04e into main Dec 12, 2025
18 checks passed

devjerry0 deleted the dev branch December 12, 2025 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: move imports to top-level in test file #1

fix: move imports to top-level in test file #1

Uh oh!

devjerry0 commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot commented Dec 12, 2025

Uh oh!

codecov-commenter commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: move imports to top-level in test file #1

fix: move imports to top-level in test file #1

Uh oh!

Conversation

devjerry0 commented Dec 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot commented Dec 12, 2025

Uh oh!

codecov-commenter commented Dec 12, 2025

Welcome to Codecov 🎉

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants