Refactor/final cleanup #3
Conversation
- Remove fork explanation (belongs in README) - Keep dual copyright (standard for forks) - Use clean, standard MIT license format
- References deleted deploy.py script - Documents outdated manual deployment process - Modern workflow is automated via GitHub Actions - Simple tag-based publishing doesn't need separate guide
- Move from MANIFEST.in to pyproject.toml - Use [tool.setuptools.package-data] for JSON files - Delete legacy MANIFEST.in file - Everything in one config file now
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR performs final cleanup and modernization of the package configuration. The main focus is on consolidating package metadata and configuration into pyproject.toml following modern Python packaging best practices, while removing obsolete documentation files.
Key Changes:
- Migrated package data specification from
MANIFEST.intopyproject.tomlwith more specific JSON file patterns - Simplified LICENSE copyright notices by removing explanatory text about the fork relationship
- Removed
DEPLOYMENT.mddocumentation file (deployment is handled by GitHub Actions workflows)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Added [tool.setuptools.package-data] section to specify JSON data files for inclusion in the package distribution |
| MANIFEST.in | Removed file as package data specification migrated to pyproject.toml |
| LICENSE | Simplified copyright notices to standard MIT format, removing fork-specific explanatory text |
| DEPLOYMENT.md | Removed deployment documentation file (deployment automated via GitHub Actions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [tool.setuptools.package-data] | ||
| contractions = ["data/*.json"] |
There was a problem hiding this comment.
The package data configuration is duplicated in both pyproject.toml and setup.py. Since the project is using pyproject.toml for configuration (with setuptools as the build backend), the package_data in setup.py should be removed to avoid potential conflicts and maintain a single source of configuration. Modern Python packaging best practices recommend consolidating all configuration in pyproject.toml.
No description provided.