-
Notifications
You must be signed in to change notification settings - Fork 0
Develop #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove fork explanation (belongs in README) - Keep dual copyright (standard for forks) - Use clean, standard MIT license format
- References deleted deploy.py script - Documents outdated manual deployment process - Modern workflow is automated via GitHub Actions - Simple tag-based publishing doesn't need separate guide
- Move from MANIFEST.in to pyproject.toml - Use [tool.setuptools.package-data] for JSON files - Delete legacy MANIFEST.in file - Everything in one config file now
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs repository maintenance by consolidating packaging configuration and simplifying documentation. The changes migrate from MANIFEST.in to pyproject.toml for package data configuration and remove internal deployment documentation.
- Adds modern setuptools package-data configuration in pyproject.toml
- Removes legacy MANIFEST.in file
- Simplifies LICENSE copyright notice by removing fork attribution details
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds [tool.setuptools.package-data] section to include JSON data files in the package |
| MANIFEST.in | Removes legacy manifest file that was used for package data inclusion |
| LICENSE | Simplifies copyright notice to just list the two copyright holders without fork explanation |
| DEPLOYMENT.md | Removes internal deployment documentation (113 lines removed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Package data already defined in pyproject.toml - Remove redundant setup.py configuration - Prevents conflicts and confusion - Verified JSON files still included in build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.