Skip to content

Conversation

@ZeroSkill1
Copy link
Contributor

  • Implemented the entirety of the friends services commands, fixing incorrect ones and adding all the missing ones.
  • Fix up the existing base Mii struct.

@TuxSH
Copy link
Collaborator

TuxSH commented Mar 6, 2025

Looks good, though, could you give more context on why you added PACKED?

@ZeroSkill1
Copy link
Contributor Author

The MiiData struct as it was before was too large. Furthermore, the bitfields weren't padded properly and thus caused extraneous padding bytes to be inserted in between the inner structs. The MiiData struct must be exactly 0x5C in size (and it wasn't before). Both friends and ACT assume this base struct to be exactly 0x5C in size.

@fincs
Copy link
Member

fincs commented Mar 6, 2025

Some of the changes add PACKED to structures that only contain 8-bit members. Why is that?

@ZeroSkill1
Copy link
Contributor Author

That must've been an oversight from when I was trying to fix up the incorrect alignments. I've removed CTR_PACKED from the inner structs that don't need it.

@ZeroSkill1 ZeroSkill1 changed the title Finalize the implementation for Friends services, fix Mii struct Implement ACT, finalize FRD implementation, fix Mii struct Mar 7, 2025
@ZeroSkill1
Copy link
Contributor Author

While I'm at it, I'm also going to add the implementation for ACT services.

@fincs
Copy link
Member

fincs commented Mar 17, 2025

Is this PR done? In any case, would you mind tidying up history a bit once you're done? Ideally there should be one commit per service.

@ZeroSkill1
Copy link
Contributor Author

ZeroSkill1 commented Mar 17, 2025

Yes, I've added everything I wanted to change.

I've reorganized the commits so each change (Mii struct, FRD, ACT) is its own separate commit.

@fincs fincs merged commit 933a3f1 into devkitPro:master Mar 17, 2025
@ZeroSkill1 ZeroSkill1 deleted the mii_friends_fixes branch March 18, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants