fix incorrect 32-bit read of 16-bit register #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code has a bug where it reads 32 bit value from IME, which is a 16 bit reg. this can cause open bus. IME is a 16 bit register and shouldn't be read from using ldr. Prevents possibly unwanted open bus behavior.
|
Are you sure the top 16 bits are open bus? If I remember correctly, a lot of IO registers are 16 bit in the documentation, but the top 16 bits just return 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this code has a bug where it reads 32 bit value from IME, which is a 16 bit reg. this can cause open bus.
IME is a 16 bit register and shouldn't be read from using ldr. Prevents possibly unwanted open bus behavior.