Skip to content

Conversation

@kzu
Copy link
Member

@kzu kzu commented Nov 13, 2024

This is prerequisite for doing dynamic codegen on the main API entry point anyway (for SponsorLink enablement).

We make the lookup for registration method calls smarter by quickly discarding invocations that don't look like our candidates, before doing any semantic analysis.

@kzu kzu added the enhancement New feature or request label Nov 13, 2024
@kzu kzu enabled auto-merge (rebase) November 13, 2024 17:14
@devlooped-bot
Copy link
Member

devlooped-bot commented Nov 13, 2024

33 passed 33 passed

🧪 Details on Ubuntu 22.04.5 LTS

✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfAddServicesPresent
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfNoServiceCollectionCalls
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissing
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissingMultipleLocations
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.ErrorIfNonTypeOf
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.NoErrorOnTypeOfAndLifetime
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.WarnIfOpenGeneric
✅ Tests.ComponentModel.ComponentModelTests.Composition
✅ Tests.ComponentModel.ComponentModelTests.RegisterSingletonService
✅ Tests.ComponentModel.ComponentModelTests.RegisterTransientService
✅ Tests.ComponentModel.ComponentModelTests.ResolvesDependency
✅ Tests.Composition.CompositionTests.CompositionLifetimes
✅ Tests.Composition.CompositionTests.RegisterKeyedService
✅ Tests.Composition.CompositionTests.RegisterSingletonService
✅ Tests.Composition.CompositionTests.RegisterTransientService
✅ Tests.Composition.CompositionTests.ResolvesDependency
✅ Tests.DependencyInjection.ConventionsTests.RegisterGenericServices
✅ Tests.DependencyInjection.GenerationTests.RegisterInternalService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterWithCustomServiceAttribute
✅ Tests.DependencyInjection.GenerationTests.RegisterWithGenericOutParameterHierarchy
✅ Tests.DependencyInjection.GenerationTests.ResolveMultipleKeys
✅ Tests.DependencyInjection.GenerationTests.ResolvesDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependencyForNonKeyed
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedFromContracts
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedTransientDependency
✅ Tests.DependencyInjection.GenerationTests.RetrieveMany

from dotnet-retest v0.6.3 on .NET 8.0.10 with 💜

This is prerequisite for doing dynamic codegen on the main API entry point anyway (for SponsorLink enablement).

We make the lookup for registration method calls smarter by quickly discarding invocations that don't look like our candidates, before doing any semantic analysis.
@kzu kzu force-pushed the dev/customization branch from 8b15dd5 to 9591872 Compare November 13, 2024 17:47
kzu added 3 commits November 13, 2024 15:23
Since we skip that for determining if the user invoked AddServices.
The StaticGenerator already provides access to the files added by default to the compilation for testing, no need to include them like we did when they were added via contentFiles by nuget.
@kzu kzu force-pushed the dev/customization branch from 0baced0 to f35a405 Compare November 13, 2024 18:24
@kzu kzu merged commit 68853c7 into main Nov 13, 2024
6 checks passed
@kzu kzu deleted the dev/customization branch November 13, 2024 18:25
@devlooped devlooped locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants