Skip to content

Optimize generator by checking invocations in the predicate #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 1 commit into from
Nov 13, 2024
Merged

Optimize generator by checking invocations in the predicate #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/DependencyInjection/IncrementalGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ bool IsExport(AttributeData attr)
// First get all AddServices(type, regex, lifetime) invocations.
var methodInvocations = context.SyntaxProvider
.CreateSyntaxProvider(
predicate: static (node, _) => node is InvocationExpressionSyntax,
predicate: static (node, _) => node is InvocationExpressionSyntax invocation && invocation.ArgumentList.Arguments.Count != 0 && GetInvokedMethodName(invocation) == nameof(AddServicesNoReflectionExtension.AddServices),
transform: static (ctx, _) => GetServiceRegistration((InvocationExpressionSyntax)ctx.Node, ctx.SemanticModel))
.Where(details => details != null)
.Collect();
Expand Down Expand Up @@ -205,21 +205,17 @@ void RegisterServicesOutput(IncrementalGeneratorInitializationContext context, I
(ctx, data) => AddPartial("AddKeyedTransient", ctx, data));
}

static ServiceRegistration? GetServiceRegistration(InvocationExpressionSyntax invocation, SemanticModel semanticModel)
static string? GetInvokedMethodName(InvocationExpressionSyntax invocation) => invocation.Expression switch
{
static string? GetInvokedMethodName(InvocationExpressionSyntax invocation) => invocation.Expression switch
{
MemberAccessExpressionSyntax memberAccess => memberAccess.Name.Identifier.Text,
IdentifierNameSyntax identifierName => identifierName.Identifier.Text,
_ => null
};

// Quick checks first without semantic analysis of any kind.
if (invocation.ArgumentList.Arguments.Count == 0 || GetInvokedMethodName(invocation) != nameof(AddServicesNoReflectionExtension.AddServices))
return null;
MemberAccessExpressionSyntax memberAccess => memberAccess.Name.Identifier.Text,
IdentifierNameSyntax identifierName => identifierName.Identifier.Text,
_ => null
};

static ServiceRegistration? GetServiceRegistration(InvocationExpressionSyntax invocation, SemanticModel semanticModel)
{
// This is somewhat expensive, so we try to first discard invocations that don't look like our
// target first (no args and wrong method name), before moving on to semantic analyis.
// target first (no args and wrong method name), in the predicate, before moving on to semantic analyis here.

var options = (CSharpParseOptions)invocation.SyntaxTree.Options;

Expand Down