Skip to content

Adopt SponsorLink v2 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzu merged 6 commits into from
Dec 3, 2024
Merged

Adopt SponsorLink v2 #127

kzu merged 6 commits into from
Dec 3, 2024

Conversation

@kzu
Copy link
Member

@kzu kzu commented Dec 3, 2024

Related to #126

kzu added 6 commits December 3, 2024 17:47
@kzu
Add SL assets from upstream via dotnet-file
ce26def
@kzu
Add preprocessor symbols from new targts to analyzer tests
61e7f11
@kzu
Add conditional DDI_ADDSERVICES for partial class emitted for registr…
222e7bd 
…ations

Since the user can turn off this at the static generator level, the incremental one should honor that too.

This means users can turn off `AddServices` being compiled into their API by defining the preprocessor constant/directive `DDI_ADDSERVICES`.
@kzu
Emit compiler warning and remarks depending on sponsoring status
e1fb5bc 
This follows the mechanism in ThisAssembly. Then generating code inside an editor, we'll emit the APIs with `[Obsolete]` if status is unknown or expired. A grace-period remark will be added too as appropriate.
@kzu
Include SL in tests and bump to net8.0
774d462
@kzu
Move samples to a separate solution, ensure they reference built package
c91801c 
We won't build this sample for now in CI, since it's not even adding a very useful example at all (it was mostly brought from Merq). Pending rewrite or deletion?
@kzu kzu added the documentation Improvements or additions to documentation label Dec 3, 2024
@kzu kzu enabled auto-merge (rebase) December 3, 2024 21:06
@devlooped-bot
Copy link
Member

devlooped-bot commented Dec 3, 2024

35 passed 35 passed

🧪 Details on Ubuntu 22.04.5 LTS

✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfAddServicesPresent
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.NoWarningIfNoServiceCollectionCalls
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissing
✅ Tests.CodeAnalysis.AddServicesAnalyzerTests.WarnIfAddServicesMissingMultipleLocations
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.ErrorIfNonTypeOf
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.NoErrorOnTypeOfAndLifetime
✅ Tests.CodeAnalysis.ConventionAnalyzerTests.WarnIfOpenGeneric
✅ Tests.ComponentModel.ComponentModelTests.Composition
✅ Tests.ComponentModel.ComponentModelTests.RegisterSingletonService
✅ Tests.ComponentModel.ComponentModelTests.RegisterTransientService
✅ Tests.ComponentModel.ComponentModelTests.ResolvesDependency
✅ Tests.Composition.CompositionTests.CompositionLifetimes
✅ Tests.Composition.CompositionTests.RegisterKeyedService
✅ Tests.Composition.CompositionTests.RegisterSingletonService
✅ Tests.Composition.CompositionTests.RegisterTransientService
✅ Tests.Composition.CompositionTests.ResolvesDependency
✅ Tests.DependencyInjection.ConventionsTests.RegisterGenericServices
✅ Tests.DependencyInjection.ConventionsTests.RegisterRepositoryServices
✅ Tests.DependencyInjection.ConventionsTests.RegisterServiceByRegex
✅ Tests.DependencyInjection.GenerationTests.RegisterInternalService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterKeyedTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterScopedService
✅ Tests.DependencyInjection.GenerationTests.RegisterSingletonService
✅ Tests.DependencyInjection.GenerationTests.RegisterTransientService
✅ Tests.DependencyInjection.GenerationTests.RegisterWithCustomServiceAttribute
✅ Tests.DependencyInjection.GenerationTests.RegisterWithGenericOutParameterHierarchy
✅ Tests.DependencyInjection.GenerationTests.ResolveMultipleKeys
✅ Tests.DependencyInjection.GenerationTests.ResolvesDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependency
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedDependencyForNonKeyed
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedFromContracts
✅ Tests.DependencyInjection.GenerationTests.ResolvesKeyedTransientDependency
✅ Tests.DependencyInjection.GenerationTests.RetrieveMany

from dotnet-retest v0.6.3 on .NET 8.0.11 with 💜

@kzu kzu merged commit b19b9e1 into main Dec 3, 2024
7 checks passed
@kzu kzu deleted the dev/sl2 branch December 3, 2024 21:07
@devlooped devlooped locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzu @devlooped-bot